Skip to content

AMS sending silently ignores empty messages #261

@tofu-rocketry

Description

@tofu-rocketry

Following #247, I noticed that we're silently ignoring empty messages.

ssm/ssm/ssm2.py

Line 493 in 0ec0b31

argo_id = self._send_msg_ams(text, msgid)

_send_msg_ams will return None for an empty message and the code here will log as if the message was sent:

ssm/ssm/ssm2.py

Line 495 in 0ec0b31

log_string = "Sent %s, Argo ID: %s" % (msgid, argo_id)

We should wrap that in an if...else and log a different message if the message wasn't sent, perhaps a warning.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions