Skip to content

Commit 690bd04

Browse files
authored
Merge pull request #5 from jkesselm/master
Revert default indent-amount
2 parents 3a624b3 + 6f418ab commit 690bd04

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/org/apache/xml/serializer/output_xml.properties

+10-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,16 @@ media-type=text/xml
4040
# xalan:content-handler="MyContentHandler"/>
4141
# ...
4242
# Note that the colon after the protocol needs to be escaped.
43-
# {http\u003a//xml.apache.org/xalan}indent-amount=0
44-
{http\u003a//xml.apache.org/xalan}indent-amount=2
43+
#
44+
# NOTE: Any change to formatting may break existing code which depends
45+
# upon the previous default formatting. True, nobody likes the
46+
# default of 0, but it's been there for two decades now and there is
47+
# probably a LOT of code which expects it. Since the current behavior
48+
# is not a bug, we really should at least try to census the user community
49+
# on that before altering it. Not that our test suite is a perfect
50+
# example of sensitivity to formatting. If we're going to alter it we should
51+
# simultaneously update the tests and/or test framework to reflect it.
52+
{http\u003a//xml.apache.org/xalan}indent-amount=0
4553
{http\u003a//xml.apache.org/xalan}content-handler=org.apache.xml.serializer.ToXMLStream
4654
{http\u003a//xml.apache.org/xalan}entities=org/apache/xml/serializer/XMLEntities
4755

0 commit comments

Comments
 (0)