Use SVN_DSO_SUFFIX_FMT definition for determining the name of the DSO

auth modules when loading them. As it is required, always setup the
SVN_DSO_SUFFIX_FMT definition even if we don't use DSO modules for FS
and RA modules on CMake and autoconf build systems.

Also this fixes incorrect loading of the auth libraries with CMake, that
builds the libraries with different names (going to be fixed soon).

* CMakeLists.txt
  (dso): Move SVN_DSO_SUFFIX_FMT setting outside from if(SVN_USE_DSO).
* configure.ac
  (dso): Move DSO settings outside from the block, executed only in case of
   enabled --enable-runtime-module-search option.
* subversion/libsvn_subr/auth.c
  (svn_auth_get_platform_specific_provider->library_name): Replace '%d.so.%d'
   constant in library name template string with SVN_DSO_SUFFIX_FMT, which
   actually should be the same on Linux, the only platform this code is
   running on, following no functional changes with autoconf.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1921144 13f79535-47bb-0310-9956-ffa450edef68

Author: rinrab

CMakeLists.txt

@@ -151,13 +151,13 @@ endif()
 
 if(SVN_USE_DSO)
   add_compile_definitions("SVN_USE_DSO")
-  string(APPEND PRIVATE_CONFIG_DEFINITIONS
-    "\n"
-    "/* Shared library file name suffix format */\n"
-    "#define SVN_DSO_SUFFIX_FMT \"%d${CMAKE_SHARED_LIBRARY_SUFFIX}\"\n"
-  )
 endif()
 
+string(APPEND PRIVATE_CONFIG_DEFINITIONS
+  "\n"
+  "/* Shared library file name suffix format */\n"
+  "#define SVN_DSO_SUFFIX_FMT \"%d${CMAKE_SHARED_LIBRARY_SUFFIX}\"\n"
+)
 add_compile_definitions("SVN_SOVERSION=1")
 
 if (SVN_ENABLE_TESTS)

configure.ac

@@ -1492,22 +1492,22 @@ AS_HELP_STRING([--enable-runtime-module-search],
       fi
       AC_DEFINE(SVN_USE_DSO, 1,
                 [Defined if svn should try to load DSOs])
-
-      dnl Mac OS X uses libname.MAJOR.SOVERSION.dylib
-      dnl Most other unixes use libname.MAJOR.so.SOVERSION
-      case "$host" in
-        *-*-darwin*)
-          AC_DEFINE(SVN_DSO_SUFFIX_FMT, ["%d.%d.dylib"],
-                    [Shared library file name suffix format])
-          ;;
-        *)
-          AC_DEFINE(SVN_DSO_SUFFIX_FMT, ["%d.so.%d"],
-                    [Shared library file name suffix format])
-          ;;
-      esac
     fi
 ])
 
+dnl Mac OS X uses libname.MAJOR.SOVERSION.dylib
+dnl Most other unixes use libname.MAJOR.so.SOVERSION
+case "$host" in
+  *-*-darwin*)
+    AC_DEFINE(SVN_DSO_SUFFIX_FMT, ["%d.%d.dylib"],
+              [Shared library file name suffix format])
+    ;;
+  *)
+    AC_DEFINE(SVN_DSO_SUFFIX_FMT, ["%d.so.%d"],
+              [Shared library file name suffix format])
+    ;;
+esac
+
 if test "$svn_enable_shared" = "no" || test "$use_dso" != "yes"; then
   AC_DEFINE(SVN_LIBSVN_RA_LINKS_RA_LOCAL, 1,
       [Defined if libsvn_ra should link against libsvn_ra_local])

subversion/libsvn_subr/auth.c

@@ -508,7 +508,7 @@ svn_auth_get_platform_specific_provider(svn_auth_provider_object_t **provider,
       const char *library_label, *library_name;
       const char *provider_function_name, *version_function_name;
       library_name = apr_psprintf(pool,
-                                  "libsvn_auth_%s-%d.so.%d",
+                                  "libsvn_auth_%s-" SVN_DSO_SUFFIX_FMT,
                                   provider_name,
                                   SVN_VER_MAJOR, SVN_SOVERSION);
       library_label = apr_psprintf(pool, "svn_%s", provider_name);