Skip to content

Commit d4ea997

Browse files
authored
chore: add @OverRide tag on some methods (#6304)
1 parent 5edcdee commit d4ea997

File tree

27 files changed

+440
-0
lines changed

27 files changed

+440
-0
lines changed

apm-checkstyle/checkStyle.xml

+1
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@
105105
<module name="TypeName">
106106
<property name="format" value="(^[A-Z][a-zA-Z0-9]*$)|(^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$)"/>
107107
</module>
108+
<module name="MissingOverride"/>
108109

109110
<!--whitespace-->
110111
<module name="GenericWhitespace"/>

apm-commons/apm-datacarrier/src/main/java/org/apache/skywalking/apm/commons/datacarrier/common/AtomicRangeInteger.java

+4
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,22 @@ public final int get() {
5454
return this.values.get(VALUE_OFFSET);
5555
}
5656

57+
@Override
5758
public int intValue() {
5859
return this.values.get(VALUE_OFFSET);
5960
}
6061

62+
@Override
6163
public long longValue() {
6264
return this.values.get(VALUE_OFFSET);
6365
}
6466

67+
@Override
6568
public float floatValue() {
6669
return this.values.get(VALUE_OFFSET);
6770
}
6871

72+
@Override
6973
public double doubleValue() {
7074
return this.values.get(VALUE_OFFSET);
7175
}

apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/CorrelationContext.java

+1
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ void handle(AbstractSpan span) {
176176
/**
177177
* Clone the context data, work for capture to cross-thread.
178178
*/
179+
@Override
179180
public CorrelationContext clone() {
180181
final CorrelationContext context = new CorrelationContext();
181182
context.data.putAll(this.data);

apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/util/ThrowableTransformer.java

+2
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,12 @@ public String convert2String(Throwable throwable, final int maxLength) {
3737
stackMessage.append(printExceptionInfo(causeException));
3838

3939
boolean isLookDeeper = printStackElement(causeException.getStackTrace(), new AppendListener() {
40+
@Override
4041
public void append(String value) {
4142
stackMessage.append(value);
4243
}
4344

45+
@Override
4446
public boolean overMaxLength() {
4547
return stackMessage.length() > maxLength;
4648
}

apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/ProtectiveShieldMatcher.java

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public ProtectiveShieldMatcher(ElementMatcher<? super T> matcher) {
4141
this.matcher = matcher;
4242
}
4343

44+
@Override
4445
public boolean matches(T target) {
4546
try {
4647
return this.matcher.matches(target);

0 commit comments

Comments
 (0)