Skip to content

Commit 24ce254

Browse files
committed
1、remove wrapped.write from server_intercepter_test method call, this method is deleted
2、change gin excepted data /notFound isError=true
1 parent 659933c commit 24ce254

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

plugins/http/server_intercepter_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ func TestServerInvokeError(t *testing.T) {
6666
wrapped, _ := invocation.Args()[0].(*writerWrapper)
6767

6868
wrapped.WriteHeader(http.StatusInternalServerError)
69-
wrapped.Write([]byte("Internal Server Error"))
7069

7170
time.Sleep(100 * time.Millisecond)
7271
_ = interceptor.AfterInvoke(invocation)

test/plugins/scenarios/gin/config/excepted.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ segmentItems:
4949
startTime: nq 0
5050
endTime: nq 0
5151
componentId: 5006
52-
isError: false
52+
isError: true
5353
spanType: Entry
5454
peer: ''
5555
skipAnalysis: false
@@ -85,7 +85,7 @@ segmentItems:
8585
startTime: gt 0
8686
endTime: gt 0
8787
componentId: 5005
88-
isError: false
88+
isError: true
8989
spanType: Exit
9090
peer: localhost:8080
9191
skipAnalysis: false

0 commit comments

Comments
 (0)