You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+8-8
Original file line number
Diff line number
Diff line change
@@ -5,19 +5,20 @@ For more details on how to report a vulnerablity see: https://www.apache.org/sec
5
5
6
6
Following this checklist to help us incorporate your contribution quickly and easily:
7
7
8
-
-[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SHIRO) filed
8
+
-[ ] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed
9
9
for the change (usually before you start working on it). Trivial changes like typos do not
10
-
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
10
+
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
11
11
-[ ] Each commit in the pull request should have a meaningful subject line and body.
12
-
-[ ] Format the pull request title like `[SHIRO-XXX] - Fixes bug in SessionManager`,
13
-
where you replace `SHIRO-XXX` with the appropriate JIRA issue. Best practice
14
-
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
12
+
-[ ] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`,
13
+
where you replace `#XXX` with the appropriate GitHub issue. Best practice
14
+
is to use the GitHub issue title in the pull request title and in the first line of the commit message.
15
15
-[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
16
+
-[ ] add `fixes #XXX` if merging the PR should close a related issue.
16
17
-[ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
17
18
-[ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
18
19
19
-
Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
20
-
In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
20
+
Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
21
+
In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`.
21
22
22
23
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
23
24
@@ -29,4 +30,3 @@ you have to acknowledge this by using the following check-box.
29
30
30
31
-[ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
31
32
-[ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
0 commit comments