Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TablesContext#findTableNames method and implement select order by, group by bind logic #34123

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Dec 23, 2024

Ref #34029.

Changes proposed in this pull request:

  • Remove TablesContext#findTableNames method and use sql bind info to replace

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@strongduanmu strongduanmu marked this pull request as draft December 23, 2024 04:53
@strongduanmu strongduanmu marked this pull request as ready for review December 24, 2024 06:52
@strongduanmu
Copy link
Member Author

image

@strongduanmu strongduanmu added this to the 5.5.2 milestone Dec 24, 2024
@strongduanmu strongduanmu changed the title Remove TablesContext#findTableNames method and use sql bind info to replace Remove TablesContext#findTableNames method and implement select order by, group by bind logic Dec 24, 2024
@FlyingZC FlyingZC merged commit cf0b19a into apache:master Dec 24, 2024
147 checks passed
@strongduanmu strongduanmu deleted the dev-1223 branch December 24, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants