Views can not be dropped under default configurations

[ayushtkn]

Describe the bug

Dropping a view on a catalog with no purge-related configuration set fails with a 403:

ForbiddenException: Unable to purge entity: view1. To enable this feature, set the Polaris
configuration DROP_WITH_PURGE_ENABLED or the catalog configuration
polaris.config.drop-with-purge.enabled

The cause is the interaction of two defaults:

• DROP_WITH_PURGE_ENABLED defaults to false
  

  polaris/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java

  Lines 424 to 432 in ffa6977

  	public static final FeatureConfiguration<Boolean> DROP_WITH_PURGE_ENABLED =
  	PolarisConfiguration.<Boolean>builder()
  	.key("DROP_WITH_PURGE_ENABLED")
  	.catalogConfig("polaris.config.drop-with-purge.enabled")
  	.legacyCatalogConfig("drop-with-purge.enabled")
  	.description(
  	"If set to true, allows tables to be dropped with the purge parameter set to true.")
  	.defaultValue(false)
  	.buildFeatureConfiguration();

• PURGE_VIEW_METADATA_ON_DROP defaults to true
  

  polaris/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java

  Lines 434 to 441 in ffa6977

  	public static final FeatureConfiguration<Boolean> PURGE_VIEW_METADATA_ON_DROP =
  	PolarisConfiguration.<Boolean>builder()
  	.key("PURGE_VIEW_METADATA_ON_DROP")
  	.catalogConfig("polaris.config.purge-view-metadata-on-drop")
  	.description(
  	"If set to true, Polaris will attempt to delete view metadata files when a view is dropped.")
  	.defaultValue(true)
  	.buildFeatureConfiguration();

LocalIcebergCatalog.dropView derives purge from the first and passes it to dropTableLike, whose guard rejects purge=true unless the second is enabled. So the shipped defaults are exactly the combination that fails.

PolarisRestCatalogIntegrationBase.testDropViewWithPurge explicitly pins the behaviour when both properties are set (DROP_WITH_PURGE_ENABLED=false + PURGE_VIEW_METADATA_ON_DROP=true → ForbiddenException)

polaris/integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java

Lines 1902 to 1907 in ffa6977

	catalogProps.put(FeatureConfiguration.DROP_WITH_PURGE_ENABLED.catalogConfig(), "false");
	catalogProps.put(FeatureConfiguration.PURGE_VIEW_METADATA_ON_DROP.catalogConfig(), "true");
	managementApi.updateCatalog(catalog, catalogProps);
	assertThatThrownBy(() -> restCatalog.dropView(id)).isInstanceOf(ForbiddenException.class);

If we want to make it work under default conditions. I see two options here: Change the default value of PURGE_VIEW_METADATA_ON_DROP or make it independent of DROP_WITH_PURGE_ENABLED and let the later gaurd only tables not Views

To Reproduce

No response

Actual Behavior

No response

Expected Behavior

No response

Additional context

No response

System information

No response

[dimas-b]

IIRC, in #2369 the default value for PURGE_VIEW_METADATA_ON_DROP was chosen to match old, hard-coded behaviour.

[dimas-b]

My take on this issue to to change PURGE_VIEW_METADATA_ON_DROP to false by default.

DROP_WITH_PURGE_ENABLED is an old flag. I'd be cautious about changing it's scope.

[ayushtkn]

Thanx @dimas-b , changing the default looks safer. I will create a PR to update the default

[zhang-arvin]

I would like to work on this issue.

[ayushtkn]

I would like to work on this issue.

@zhang-arvin I already have a PR for this, #5322 :-)