PHOENIX-7566 ZK to SystemTable Sync and Event Reactor for Failover

Author: Ritesh Garg

phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java

@@ -349,16 +349,16 @@ public void setHAGroupStatusIfNeeded(HAGroupStoreRecord.HAGroupState haGroupStat
                             + " checking if state is already updated in local cache", e);
                     // Check against current cached record,
                     // hoping that record is updated in local cache.
-                    Pair<HAGroupStoreRecord, Stat> cachedRecord 
+                    Pair<HAGroupStoreRecord, Stat> cachedRecord
                             = fetchCacheRecordAndPopulateZKIfNeeded(pathChildrenCache, ClusterType.LOCAL);
                     currentHAGroupStoreRecord = cachedRecord.getLeft();
                     Stat previousHAGroupStoreRecordStat = currentHAGroupStoreRecordStat;
                     currentHAGroupStoreRecordStat = cachedRecord.getRight();
                     if (currentHAGroupStoreRecord != null
                             && currentHAGroupStoreRecord.getHAGroupState()
                             == haGroupState)  {
-                        LOGGER.debug("HAGroupStoreRecord for HA group {} is already updated" 
-                                        + "with state {}, no need to update", 
+                        LOGGER.debug("HAGroupStoreRecord for HA group {} is already updated"
+                                        + "with state {}, no need to update",
                                 haGroupName, haGroupState);
                         return;
                     // Check if the cached version is not updated, only then check with ZK.
@@ -372,7 +372,7 @@ public void setHAGroupStatusIfNeeded(HAGroupStoreRecord.HAGroupState haGroupStat
                                     = phoenixHaAdmin.getHAGroupStoreRecordInZooKeeper(haGroupName)
                                     .getLeft();
                             if (currentHAGroupStoreRecord != null
-                                    && currentHAGroupStoreRecord.getHAGroupState() 
+                                    && currentHAGroupStoreRecord.getHAGroupState()
                                     == haGroupState) {
                                 LOGGER.debug("HAGroupStoreRecord for HA group {} is already "
                                                 + "updated with state {}, no need to update",
@@ -457,7 +457,7 @@ private void initializeZNodeIfNeeded() throws IOException, SQLException {
         HAGroupStoreRecord haGroupStoreRecord = cacheRecordFromZK.getLeft();
         // Only if the ZNode is not present, we need to create it from System Table
         if (haGroupStoreRecord == null) {
-            SystemTableHAGroupRecord systemTableRecord 
+            SystemTableHAGroupRecord systemTableRecord
                     = getSystemTableHAGroupRecord(this.haGroupName);
             Preconditions.checkNotNull(systemTableRecord,
                     "System Table HAGroupRecord cannot be null");
@@ -696,7 +696,7 @@ private void updateSystemTableHAGroupRecordSilently(String haGroupName,
             pstmt.executeUpdate();
             conn.commit();
         } catch (Exception e) {
-            LOGGER.error("Failed to update system table on best" 
+            LOGGER.error("Failed to update system table on best"
                     + "effort basis for HA group {}, error: {}", haGroupName, e);
         }
     }
@@ -718,7 +718,7 @@ private void startPeriodicSyncJob() {
                     DEFAULT_HA_GROUP_STORE_SYNC_INTERVAL_SECONDS);
 
             // Add jitter to initial delay
-            long jitterSeconds 
+            long jitterSeconds
                     = ThreadLocalRandom.current().nextLong(0, SYNC_JOB_MAX_JITTER_SECONDS + 1);
 
             LOGGER.info("Starting periodic sync job for HA group {} "

phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreManager.java

@@ -124,7 +124,7 @@ HAGroupStoreRecord.HAGroupState determineTarget(
         return transitions;
     }
 
-    private static Map<HAGroupStoreRecord.HAGroupState, TargetStateResolver> 
+    private static Map<HAGroupStoreRecord.HAGroupState, TargetStateResolver>
     createLocalStateTransitions() {
         Map<HAGroupStoreRecord.HAGroupState, TargetStateResolver> transitions = new HashMap<>();
         // Local abort transitions - these are simple transitions (no condition check)

phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java

@@ -631,7 +631,7 @@ public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,
               throw new IOException("HAGroupStoreManager is null "
                       + "for current cluster, check configuration");
           }
-          String tableName 
+          String tableName
                   = c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString();
           // We don't want to check for mutation blocking for the system ha group table
           if (!tableName.equals(SYSTEM_HA_GROUP_NAME)) {