Thanks for the patch @sadanand48 . Have a few doubts with the implementation

Pull request overview

This PR reduces the Bootstrap write lock time during OM bootstrapping by refactoring the checkpoint streaming process. The key change is separating the file collection phase (which creates hardlinks while holding the lock) from the actual tar streaming phase (which now happens outside the lock).

Changes:

• Introduced OMDBArchiver class to manage hardlink creation and deferred tar writing
• Refactored OMDBCheckpointServletInodeBasedXfer to collect files under lock and write outside lock
• Updated tests to work with the new two-phase approach

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 15 comments.

    try {
      Instant start = Instant.now();
      OutputStream outputStream = response.getOutputStream();
      omdbArchiver.writeToArchive(getConf(), outputStream);
      Instant end = Instant.now();
      long duration = Duration.between(start, end).toMillis();
      LOG.info("Time taken to write the checkpoint to response output " +
          "stream: {} milliseconds", duration);
    } catch (IOException e) {
      LOG.error("unable to write to archive stream", e);
    } finally {
      try {
        if (tmpdir != null) {
          FileUtils.deleteDirectory(tmpdir.toFile());
        }
      } catch (IOException e) {
        LOG.error("unable to delete: " + tmpdir, e.toString());
      }
    }
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.