Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffer should support split_to and split_off #4593

Open
Xuanwo opened this issue May 10, 2024 · 8 comments · May be fixed by #4598
Open

Buffer should support split_to and split_off #4593

Xuanwo opened this issue May 10, 2024 · 8 comments · May be fixed by #4598
Assignees
@hanxuanliang
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented May 10, 2024

Buffer doesn't provide split related API makes it hard to use.
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed labels May 10, 2024
@hanxuanliang
Copy link
Contributor

I feel that this is a good opportunity to delve into OpenDAL. May I give this issue a try?

@hanxuanliang
Copy link
Contributor

Is the buffer here referring to the opendal::Buffer within the core?

buffer.rs

@Xuanwo
Copy link
Member Author

Xuanwo commented May 11, 2024

I feel that this is a good opportunity to delve into OpenDAL. May I give this issue a try?

Welcome, and thanks in advance!

Is the buffer here referring to the opendal::Buffer within the core?

Yes.

@hanxuanliang hanxuanliang linked a pull request May 11, 2024 that will close this issue
Draft
@Xuanwo Xuanwo changed the title Buffer should support split, split_to and split_off Buffer should support split_to and split_off Jul 1, 2024
@Yashika-code
Copy link

Hi , I am interested to solving this issue .
Can, you please explain this ?

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 24, 2024

Hi , I am interested to solving this issue . Can, you please explain this ?

Hi, thank you so much for your enthusiasm. Let's tackle the tasks one by one and learn how OpenDAL works, as well as how to contribute to it gradually. I mean, we still have many remaining tasks to address in the PR #5442. Let's meet there instead.

@Yashika-code
Copy link

Yashika-code commented Dec 24, 2024 •
edited
Loading

@Xuanwo how can I add that ? Can you please explain it some !!

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 24, 2024

@Xuanwo how can I add that ? Can you please explain it some !!

Hi, please complete #5442 first before proceeding further. Otherwise, we might end up repeating the same errors again.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 26, 2024

@Xuanwo is #5442 now completed or not ?

No. I'm a bit confused as to why you think it's complete. You haven't made any changes, and none of todo tasks have been resolved.

If completed then I move further for this problem and you please explain it ?

Please ensure the discussion on #5442 is completed before taking on additional issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanxuanliang hanxuanliang

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core/types): add new buffer util fns hanxuanliang/opendal
3 participants
@Xuanwo @hanxuanliang @Yashika-code