feat(core/types): change oio::BlockingReader to Arc<dyn oio::BlockingRead>

Author: hoslo

core/src/layers/type_eraser.rs

@@ -88,7 +88,7 @@ impl<A: Access> LayeredAccess for TypeEraseAccessor<A> {
     fn blocking_read(&self, path: &str, args: OpRead) -> Result<(RpRead, Self::BlockingReader)> {
         self.inner
             .blocking_read(path, args)
-            .map(|(rp, r)| (rp, Box::new(r) as oio::BlockingReader))
+            .map(|(rp, r)| (rp, Arc::new(r) as oio::BlockingReader))
     }
 
     fn blocking_write(&self, path: &str, args: OpWrite) -> Result<(RpWrite, Self::BlockingWriter)> {

core/src/raw/oio/read/api.rs

@@ -155,8 +155,8 @@ impl<T: ReadDyn + ?Sized> Read for Arc<T> {
     }
 }
 
-/// BlockingReader is a boxed dyn `BlockingRead`.
-pub type BlockingReader = Box<dyn BlockingRead>;
+/// BlockingReader is a arc dyn `BlockingRead`.
+pub type BlockingReader = Arc<dyn BlockingRead>;
 
 /// Read is the trait that OpenDAL returns to callers.
 pub trait BlockingRead: Send + Sync {
@@ -199,9 +199,9 @@ impl BlockingRead for Buffer {
     }
 }
 
-/// `Box<dyn BlockingRead>` won't implement `BlockingRead` automatically.
+/// `Arc<dyn BlockingRead>` won't implement `BlockingRead` automatically.
 /// To make BlockingReader work as expected, we must add this impl.
-impl<T: BlockingRead + ?Sized> BlockingRead for Box<T> {
+impl<T: BlockingRead + ?Sized> BlockingRead for Arc<T> {
     fn read_at(&self, offset: u64, limit: usize) -> Result<Buffer> {
         (**self).read_at(offset, limit)
     }

core/src/types/blocking_read/blocking_reader.rs

@@ -22,7 +22,6 @@ use std::ops::RangeBounds;
 use bytes::Buf;
 use bytes::BufMut;
 
-use crate::raw::oio::BlockingRead;
 use crate::raw::*;
 use crate::*;