OFBIZ-13311 Improved: Rewrite UtilCacheTest #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtchaboussie
changed the title
added 2 commits
November 24, 2025 16:32
(OFBIZ-13311) Rewrites the test class UtilCacheTest. Changes the variable names to make them more clear and moves the test utility objects to a dedicated new class. Also removes the GenericTestCaseBase, that was used only in the UtilCacheTest. Deleted a part of the testExpire test method, that was based on the useAllMemory method, which is highly OS or hardware dependant making unit test dependant as well. Thanks: Nicolas for the help in analyzing.
gtchaboussie
force-pushed
the
OFBIZ-13311
branch
from
6cff1d8 to
2caa71f
Compare
added 2 commits
November 24, 2025 16:47
Removes the Serializable interface from the test declaration. Still successes, and there doesn't seems to be any advantage to it.
Removes the exception from test signature and fails the test in case of Exception.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(OFBIZ-13311)
Improved: Rewrites the test class UtilCacheTest.
Changes the variable names to make them more clear and moves the test utility objects to a dedicated new class.
Also removes the GenericTestCaseBase, that was used only in the UtilCacheTest.
Deleted a part of the testExpire test method, that was based on the useAllMemory method, which is highly OS or hardware dependant making unit test dependant as well.
Thanks: Nicolas for the help in analyzing.