Skip to content

Commit 057e880

Browse files
committed
NIFI-15018 Modified property names.
1 parent 44e1320 commit 057e880

File tree

8 files changed

+21
-9
lines changed

8 files changed

+21
-9
lines changed

nifi-extension-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ abstract class AbstractEmailProcessor<T extends AbstractMailReceiver> extends Ab
139139
.addValidator(StandardValidators.BOOLEAN_VALIDATOR)
140140
.build();
141141
static final PropertyDescriptor CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
142-
.name("Connection timeout")
142+
.name("Connection Timeout")
143143
.description("The amount of time to wait to connect to Email server")
144144
.required(true)
145145
.addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)

nifi-extension-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class JdbcProperties {
2727
public static final String OLD_DEFAULT_SCALE_PROPERTY_NAME = "dbf-default-scale";
2828

2929
public static final PropertyDescriptor NORMALIZE_NAMES_FOR_AVRO = new PropertyDescriptor.Builder()
30-
.name("Normalize Table/Column Names")
30+
.name("Normalize Table and Column Names")
3131
.description("Whether to change non-Avro-compatible characters in column names to Avro-compatible characters. For example, colons and periods "
3232
+ "will be changed to underscores in order to build a valid Avro record.")
3333
.allowableValues("true", "false")

nifi-extension-bundles/nifi-extension-utils/nifi-dbcp-base/src/main/java/org/apache/nifi/dbcp/utils/DBCPProperties.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ private DBCPProperties() {
110110
.build();
111111

112112
public static final PropertyDescriptor VALIDATION_QUERY = new PropertyDescriptor.Builder()
113-
.name("Validation query")
113+
.name("Validation Query")
114114
.description("Validation query used to validate connections before returning them. "
115115
+ "When connection is invalid, it gets dropped and new valid connection will be returned. "
116116
+ "Note!! Using validation might have some performance penalty.")
@@ -130,7 +130,7 @@ private DBCPProperties() {
130130
.build();
131131

132132
public static final PropertyDescriptor MAX_IDLE = new PropertyDescriptor.Builder()
133-
.name("Max Idle Connections")
133+
.name("Maximum Idle Connections")
134134
.description("The maximum number of connections that can remain idle in the pool without extra ones being " +
135135
"released. Set to any negative value to allow unlimited idle connections.")
136136
.defaultValue(DefaultDataSourceValues.MAX_IDLE.getValue())
@@ -140,7 +140,7 @@ private DBCPProperties() {
140140
.build();
141141

142142
public static final PropertyDescriptor MAX_CONN_LIFETIME = new PropertyDescriptor.Builder()
143-
.name("Max Connection Lifetime")
143+
.name("Maximum Connection Lifetime")
144144
.description("The maximum lifetime of a connection. After this time is exceeded the " +
145145
"connection will fail the next activation, passivation or validation test. A value of zero or less " +
146146
"means the connection has an infinite lifetime.")

nifi-extension-bundles/nifi-extension-utils/nifi-event-listen/src/main/java/org/apache/nifi/processor/util/listen/ListenerProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public class ListenerProperties {
125125
.required(true)
126126
.build();
127127
public static final PropertyDescriptor WORKER_THREADS = new PropertyDescriptor.Builder()
128-
.name("Max Number of Worker Threads")
128+
.name("Worker Threads")
129129
.description("The maximum number of worker threads available for servicing TCP connections.")
130130
.addValidator(StandardValidators.createLongValidator(1, 65535, true))
131131
.defaultValue("2")

nifi-extension-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FetchFileTransfer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public abstract class FetchFileTransfer extends AbstractProcessor {
117117
.build();
118118

119119
public static final PropertyDescriptor FILE_NOT_FOUND_LOG_LEVEL = new PropertyDescriptor.Builder()
120-
.name("Log level when file not found")
120+
.name("Log Level When File Not Found")
121121
.description("Log level to use in case the file does not exist when the processor is triggered")
122122
.allowableValues(LogLevel.values())
123123
.defaultValue(LogLevel.ERROR.toString()) // backward compatibility support

nifi-extension-bundles/nifi-extension-utils/nifi-file-transfer/src/main/java/org/apache/nifi/processor/util/file/transfer/FileTransfer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ default String getAbsolutePath(FlowFile flowFile, String remotePath) throws IOEx
142142
String OLD_FOLLOW_SYMLINK_PROPERTY_NAME = "follow-symlink";
143143

144144
PropertyDescriptor FOLLOW_SYMLINK = new PropertyDescriptor.Builder()
145-
.name("Follow symlink")
145+
.name("Follow Symbolic Links")
146146
.description("If true, will pull even symbolic files and also nested symbolic subdirectories; otherwise, will not read symbolic files and will not traverse symbolic link subdirectories")
147147
.required(true)
148148
.defaultValue("false")

nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-hadoop-record-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractPutHDFSRecord.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public abstract class AbstractPutHDFSRecord extends AbstractHadoopProcessor {
8686
.build();
8787

8888
public static final PropertyDescriptor UMASK = new PropertyDescriptor.Builder()
89-
.name("Permissions umask")
89+
.name("Permissions Umask")
9090
.description("A umask represented as an octal number which determines the permissions of files written to HDFS. " +
9191
"This overrides the Hadoop Configuration dfs.umaskmode")
9292
.addValidator(HadoopValidators.UMASK_VALIDATOR)

nifi-extension-bundles/nifi-snowflake-bundle/nifi-snowflake-services/src/main/java/org/apache/nifi/snowflake/service/SnowflakeComputingConnectionPool.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.apache.nifi.expression.AttributeExpression;
3838
import org.apache.nifi.expression.ExpressionLanguageScope;
3939
import org.apache.nifi.key.service.api.PrivateKeyService;
40+
import org.apache.nifi.migration.PropertyConfiguration;
4041
import org.apache.nifi.oauth2.OAuth2AccessTokenProvider;
4142
import org.apache.nifi.processor.exception.ProcessException;
4243
import org.apache.nifi.processor.util.StandardValidators;
@@ -200,6 +201,17 @@ public class SnowflakeComputingConnectionPool extends AbstractDBCPConnectionPool
200201
SOFT_MIN_EVICTABLE_IDLE_TIME
201202
);
202203

204+
@Override
205+
public void migrateProperties(PropertyConfiguration config) {
206+
config.renameProperty(DBCPProperties.OLD_VALIDATION_QUERY_PROPERTY_NAME, VALIDATION_QUERY.getName());
207+
config.renameProperty(DBCPProperties.OLD_MIN_IDLE_PROPERTY_NAME, MIN_IDLE.getName());
208+
config.renameProperty(DBCPProperties.OLD_MAX_IDLE_PROPERTY_NAME, MAX_IDLE.getName());
209+
config.renameProperty(DBCPProperties.OLD_MAX_CONN_LIFETIME_PROPERTY_NAME, MAX_CONN_LIFETIME.getName());
210+
config.renameProperty(DBCPProperties.OLD_EVICTION_RUN_PERIOD_PROPERTY_NAME, EVICTION_RUN_PERIOD.getName());
211+
config.renameProperty(DBCPProperties.OLD_MIN_EVICTABLE_IDLE_TIME_PROPERTY_NAME, MIN_EVICTABLE_IDLE_TIME.getName());
212+
config.renameProperty(DBCPProperties.OLD_SOFT_MIN_EVICTABLE_IDLE_TIME_PROPERTY_NAME, SOFT_MIN_EVICTABLE_IDLE_TIME.getName());
213+
}
214+
203215
@Override
204216
protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
205217
return PROPERTY_DESCRIPTORS;

0 commit comments

Comments
 (0)