-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix toString()
method in configuration implementations
#3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ppkarwasz I have made the requested changes. #3658 Please review |
Why? This is not better since are now loosing information that was previously provided. |
hi @garydgregory , instead of AbstractConfiguration , shall I put my changes to all derived classes so that it can retain the additional info of subclasses. |
Description
PR #2941 introduces some basic logging of the most important
Configuration
lifecycle events at anINFO
level. The messages are meant to convey:Unfortunately this information only appears in
XmlConfiguration
:logging-log4j2/log4j-core/src/main/java/org/apache/logging/log4j/core/config/xml/XmlConfiguration.java
Lines 340 to 343 in 86781fd
JsonConfiguration
only prints the name of the configuration file, whilePropertiesConfiguration
does not have atoString()
method at all:We probably should add the
toString()
method toAbstractConfiguration
and remove it from its derived classes.The text was updated successfully, but these errors were encountered: