Move comments from caller to function declaration

Author: cyningsun

src/storage/redis_db.cc

@@ -191,8 +191,6 @@ rocksdb::Status Database::MDel(engine::Context &ctx, const std::vector<Slice> &k
     if (statuses[i].IsNotFound()) continue;
 
     Metadata metadata(kRedisNone, false);
-    // Explicit construct a rocksdb::Slice to avoid the implicit conversion from
-    // PinnableSlice to Slice.
     auto s = metadata.Decode(rocksdb::Slice(pin_values[i].data(), pin_values[i].size()));
     if (!s.ok()) continue;
     if (metadata.Expired()) continue;
@@ -233,8 +231,6 @@ rocksdb::Status Database::Exists(engine::Context &ctx, const std::vector<Slice>
     if (!statuses[i].ok() && !statuses[i].IsNotFound()) return statuses[i];
     if (statuses[i].ok()) {
       Metadata metadata(kRedisNone, false);
-      // Explicit construct a rocksdb::Slice to avoid the implicit conversion from
-      // PinnableSlice to Slice.
       auto s = metadata.Decode(rocksdb::Slice(pin_values[i].data(), pin_values[i].size()));
       if (!s.ok()) return s;
       if (!metadata.Expired()) *ret += 1;

src/storage/redis_metadata.h

@@ -199,7 +199,10 @@ class Metadata {
   bool IsEmptyableType() const;
 
   virtual void Encode(std::string *dst) const;
+
+  // Calls remove_prefix() internally and would modify the original `input` state.
   [[nodiscard]] virtual rocksdb::Status Decode(Slice *input);
+
   [[nodiscard]] rocksdb::Status Decode(Slice input);
 
   bool operator==(const Metadata &that) const;