[HUDI-8789] Dropping hbase deps from presto/trino bundle #12532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trino : does not seem to depend on the bundle anymore. So it seem safe to drop both commons-lang and guava. I kept proto since the native reader could also use this IIRC |
codope
approved these changes
Dec 21, 2024
yihua
approved these changes
Dec 21, 2024
yihua
reviewed
Dec 21, 2024
|
|
||
| <!--protobuf needs to be shaded because HBase 1.2.3 needs it at runtime, but Presto runtime does not have this | ||
| dependency--> | ||
| <!--protobuf needs to be shaded because HBase 1.2.3 and our native reader needs it at runtime, |
There was a problem hiding this comment.
We can also revisit protobuf dependency in a follow-up since HBase 2.4.9 also shaded protobuf IIRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Presto, Trino bundles need to rely on native HFile reader going forward.
Risk level (write none, low medium or high below)
medium: need to be ultimately tested on trino/presto side.
Documentation Update
none
Contributor's checklist