From 7b0fc8c452247673bcc588f81902e10606d99ec8 Mon Sep 17 00:00:00 2001 From: Ankita Victor-Levi Date: Tue, 28 Apr 2026 16:38:44 +0530 Subject: [PATCH 1/2] Remove unused configs --- cpp/velox/config/VeloxConfig.h | 1 - .../src/main/scala/org/apache/gluten/config/GlutenConfig.scala | 3 --- 2 files changed, 4 deletions(-) diff --git a/cpp/velox/config/VeloxConfig.h b/cpp/velox/config/VeloxConfig.h index cc277991f6f..535d4fa6cb0 100644 --- a/cpp/velox/config/VeloxConfig.h +++ b/cpp/velox/config/VeloxConfig.h @@ -79,7 +79,6 @@ const std::string kSparkBloomFilterExpectedNumItems = "spark.sql.optimizer.runti const std::string kSparkBloomFilterNumBits = "spark.sql.optimizer.runtime.bloomFilter.numBits"; const std::string kSparkBloomFilterMaxNumBits = "spark.sql.optimizer.runtime.bloomFilter.maxNumBits"; const std::string kSparkBloomFilterMaxNumItems = "spark.sql.optimizer.runtime.bloomFilter.maxNumItems"; -const std::string kBloomFilterExpectedNumItems = "spark.gluten.sql.columnar.backend.velox.bloomFilter.expectedNumItems"; const std::string kBloomFilterNumBits = "spark.gluten.sql.columnar.backend.velox.bloomFilter.numBits"; const std::string kBloomFilterMaxNumBits = "spark.gluten.sql.columnar.backend.velox.bloomFilter.maxNumBits"; const std::string kVeloxSplitPreloadPerDriver = "spark.gluten.sql.columnar.backend.velox.SplitPreloadPerDriver"; diff --git a/gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala b/gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala index 2f8155ce70e..2ef4c022d01 100644 --- a/gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala +++ b/gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala @@ -480,9 +480,6 @@ object GlutenConfig extends ConfigRegistry { SQLConf.RUNTIME_BLOOM_FILTER_MAX_NUM_ITEMS.key, "spark.io.compression.codec", "spark.sql.decimalOperations.allowPrecisionLoss", - "spark.gluten.sql.columnar.backend.velox.bloomFilter.expectedNumItems", - "spark.gluten.sql.columnar.backend.velox.bloomFilter.numBits", - "spark.gluten.sql.columnar.backend.velox.bloomFilter.maxNumBits", // s3 config SPARK_S3_ACCESS_KEY, SPARK_S3_SECRET_KEY, From bff6182ff6d1bb0ccffbc7eb35451bad9898d144 Mon Sep 17 00:00:00 2001 From: Ankita Victor-Levi Date: Fri, 8 May 2026 14:14:14 +0530 Subject: [PATCH 2/2] Address PR comments --- cpp/velox/config/VeloxConfig.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/cpp/velox/config/VeloxConfig.h b/cpp/velox/config/VeloxConfig.h index 535d4fa6cb0..b20758788d4 100644 --- a/cpp/velox/config/VeloxConfig.h +++ b/cpp/velox/config/VeloxConfig.h @@ -79,8 +79,6 @@ const std::string kSparkBloomFilterExpectedNumItems = "spark.sql.optimizer.runti const std::string kSparkBloomFilterNumBits = "spark.sql.optimizer.runtime.bloomFilter.numBits"; const std::string kSparkBloomFilterMaxNumBits = "spark.sql.optimizer.runtime.bloomFilter.maxNumBits"; const std::string kSparkBloomFilterMaxNumItems = "spark.sql.optimizer.runtime.bloomFilter.maxNumItems"; -const std::string kBloomFilterNumBits = "spark.gluten.sql.columnar.backend.velox.bloomFilter.numBits"; -const std::string kBloomFilterMaxNumBits = "spark.gluten.sql.columnar.backend.velox.bloomFilter.maxNumBits"; const std::string kVeloxSplitPreloadPerDriver = "spark.gluten.sql.columnar.backend.velox.SplitPreloadPerDriver"; const std::string kHashProbeDynamicFilterPushdownEnabled =