This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Commit a7ab3ce
committed
This diff contains the following fixes:
* Once the OOC is at OFFLAODING state, it may offload data to disk indefinitely. We should call GC manually and get OOC out of OFFLOADING if anything has changed in computation/communication pattern.
Fixes a "if" statement which entirely disabled regression for memory estimation.
* Interleaving of in resetting and calculating memory estimation potentially can cause data race.
* The superstep count in memory estimator was not coherent throughout the calculation.
* Sometime the memory estimator's accuracy is not good. We should fall back to a threshold-based scheme relying on a more pessimistic memory usage report (such as the one given by JVM – memory usage includes garbage data too, but it can be used as a pessimistic estimate, as it is currently used in ThresholdBasedOracle).
More tuning is needed for a smooth memory estimation mechanism.
"mvn clean install" passes all tests and checks.1 parent ea7753f commit a7ab3ce
File tree
2 files changed
+228
-102
lines changed- giraph-core/src/main/java/org/apache/giraph/ooc
- policy
2 files changed
+228
-102
lines changedLines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
426 | 426 | | |
427 | 427 | | |
428 | 428 | | |
429 | | - | |
| 429 | + | |
430 | 430 | | |
431 | 431 | | |
432 | 432 | | |
433 | | - | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
434 | 437 | | |
435 | 438 | | |
436 | 439 | | |
| |||
489 | 492 | | |
490 | 493 | | |
491 | 494 | | |
492 | | - | |
| 495 | + | |
493 | 496 | | |
494 | 497 | | |
495 | 498 | | |
| |||
0 commit comments