[Q/A][Java SDK (Component)] dubbo3.2.0 request header problem

[HollyWtk]

Pre-check

• I am sure that all the content I provide is in English.

Apache Dubbo Component

Java SDK (apache/dubbo)

Details

I want to combine SpringCloud Gateway and Dubbo REST protocol to do custom routing, and found that NettyHandler must capitalize the request header to get the request header, which conflicts with the request of Gateway, this is a bug or you need to handle the request header separately

Code of Conduct

• I agree to follow this project's Code of Conduct

[AlbumenJ]

Which version do you use?

[HollyWtk]

3.2.0 NettyHandler->dohandler()->acceptSupportJudge()->getAcceptMediaType()->RestHeaderEnum.ACCEPT

[suncairong163]

Do you mean SpringCloud Gateway request is not contain Accept header? and the next route is Dubbo rest protocol request must have Accept header?

[suncairong163]

SpringCloud Gateway will change the request header to lowercase, while the enumeration of Dubbo source code is uppercase, e.g. accept=/ will get the null value

I have test this case ,it is support to get by lower case accept header ,and the soure support code is

org.apache.dubbo.rpc.protocol.rest.request.NettyRequestFacade#getHeader

public String getHeader(String name) {

    List<String> values = headers.get(name);

    if (values == null && name != null) {
        values = headers.get(name.toLowerCase());
    }

    if (values == null || values.isEmpty()) {
        return null;
    } else {
        return values.get(0);
    }
}

[suncairong163]

and I can not recurrent your problem, can you give me test case for me to recurrent?

[HollyWtk]

org.apache.dubbo.rpc.protocol.rest.handler#getAcceptMediaType
in dubbo-3.2.0
org.apache.dubbo.rpc.protocol.rest.request.NettyRequestFacade#getHeader
public String getHeader(String name) {

    List<String> values = headers.get(name);

    if (values == null || values.isEmpty()) {
        return null;
    } else {
        return values.get(0);
    }

}

Is it inconsistent that the version we are talking about, I just checked the code for dubbo3.2.0 and the getHeader method does not become lowercase

[aofall]

Is it inconsistent that the version we are talking about, I just checked the code for dubbo3.2.0 and the getHeader method does not become lowercase

This part of the code is included in version 3.2.8, you can try to upgrade the dubbo version. The latest version is 3.2.13

[HollyWtk]

ok thank you

[suncairong163]

ok，i will fix the bug

…

---- Replied Message ---- | From | ***@***.***> | | Date | 06/07/2024 17:19 | | To | apache/dubbo ***@***.***> | | Cc | suncairong163 ***@***.***>, Comment ***@***.***> | | Subject | Re: [apache/dubbo] [Q/A][Java SDK (Component)] dubbo3.2.0 request header problem (Discussion #14279) | SpringCloud Gateway will change the request header to lowercase, while the enumeration of Dubbo source code is uppercase, e.g. accept=/ will get the null value — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>