Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](auditlog)Fix auditlog NPE #45772

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[fix](auditlog)Fix auditlog NPE #45772

merged 1 commit into from
Dec 23, 2024

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Dec 23, 2024

What problem does this PR solve?

Don't call MetricRepo if it is not initialized to avoid NPE.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 23, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review December 23, 2024 02:56
@Jibing-Li
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39771 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit daadd9f012a2c401ca1c605c43edb0707c60b75c, data reload: false

------ Round 1 ----------------------------------
q1	17589	7425	7275	7275
q2	2048	182	173	173
q3	10717	1096	1209	1096
q4	10558	786	697	697
q5	7623	2692	2655	2655
q6	241	149	145	145
q7	979	632	591	591
q8	9811	1857	1955	1857
q9	6980	6406	6417	6406
q10	7035	2315	2275	2275
q11	475	260	261	260
q12	417	230	223	223
q13	17772	2947	2945	2945
q14	233	220	212	212
q15	577	511	510	510
q16	651	570	600	570
q17	981	632	585	585
q18	7250	6644	6675	6644
q19	1345	1023	962	962
q20	472	179	179	179
q21	4187	3278	3197	3197
q22	376	314	320	314
Total cold run time: 108317 ms
Total hot run time: 39771 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7301	7283	7237	7237
q2	332	227	227	227
q3	2862	2862	2947	2862
q4	2054	1843	1837	1837
q5	5647	5613	5632	5613
q6	225	143	140	140
q7	2230	1831	1797	1797
q8	3366	3523	3552	3523
q9	8932	8980	8928	8928
q10	3593	3543	3513	3513
q11	615	507	510	507
q12	787	580	640	580
q13	12336	3146	3093	3093
q14	302	271	271	271
q15	557	512	495	495
q16	684	650	619	619
q17	1850	1638	1577	1577
q18	8275	7761	7608	7608
q19	1701	1484	1563	1484
q20	2097	1850	1894	1850
q21	5560	5391	5326	5326
q22	643	580	543	543
Total cold run time: 71949 ms
Total hot run time: 59630 ms

@Jibing-Li
Copy link
Contributor Author

run cloud_p0

@doris-robot
Copy link

TPC-DS: Total hot run time: 196194 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit daadd9f012a2c401ca1c605c43edb0707c60b75c, data reload: false

query1	1298	973	895	895
query2	6201	2434	2405	2405
query3	11101	4576	4575	4575
query4	33091	23250	23290	23250
query5	4814	460	443	443
query6	282	197	192	192
query7	3998	303	309	303
query8	312	235	237	235
query9	9397	2711	2692	2692
query10	497	246	241	241
query11	18019	14989	15442	14989
query12	158	102	101	101
query13	1647	438	411	411
query14	10961	7463	7805	7463
query15	300	185	194	185
query16	8072	443	474	443
query17	2164	626	599	599
query18	2226	329	351	329
query19	356	157	152	152
query20	121	114	114	114
query21	221	103	104	103
query22	4856	4655	4464	4464
query23	34322	33882	33548	33548
query24	10307	2533	2561	2533
query25	607	398	392	392
query26	1346	151	146	146
query27	2765	331	333	331
query28	7515	2450	2433	2433
query29	867	418	421	418
query30	229	149	156	149
query31	1083	860	854	854
query32	102	76	57	57
query33	768	323	288	288
query34	1073	532	532	532
query35	895	782	763	763
query36	1108	953	962	953
query37	144	74	73	73
query38	4170	4193	4135	4135
query39	1503	1432	1450	1432
query40	214	101	98	98
query41	43	41	48	41
query42	123	101	98	98
query43	532	506	513	506
query44	1311	823	853	823
query45	191	172	176	172
query46	1177	716	736	716
query47	2032	1961	1976	1961
query48	413	318	341	318
query49	993	384	383	383
query50	851	392	399	392
query51	7360	7223	7259	7223
query52	104	90	92	90
query53	257	189	182	182
query54	1116	405	424	405
query55	85	80	81	80
query56	256	242	251	242
query57	1278	1163	1128	1128
query58	244	218	226	218
query59	3473	3117	3083	3083
query60	279	252	253	252
query61	119	111	112	111
query62	870	686	704	686
query63	225	192	215	192
query64	3858	708	679	679
query65	3295	3283	3314	3283
query66	766	305	311	305
query67	16401	15564	15643	15564
query68	6362	540	542	540
query69	510	270	251	251
query70	1150	1130	1063	1063
query71	522	260	244	244
query72	6948	4086	4056	4056
query73	806	359	363	359
query74	10559	8809	8823	8809
query75	4204	2593	2614	2593
query76	4442	1054	1134	1054
query77	683	286	278	278
query78	10197	9343	9510	9343
query79	1137	610	591	591
query80	788	411	427	411
query81	502	222	220	220
query82	217	114	123	114
query83	193	149	141	141
query84	279	76	66	66
query85	994	300	316	300
query86	356	306	325	306
query87	4474	4667	4304	4304
query88	4046	2209	2185	2185
query89	429	288	297	288
query90	2085	186	185	185
query91	139	103	102	102
query92	59	57	51	51
query93	1867	543	542	542
query94	822	280	286	280
query95	352	247	251	247
query96	621	277	271	271
query97	2904	2667	2692	2667
query98	216	203	194	194
query99	1544	1348	1287	1287
Total cold run time: 307169 ms
Total hot run time: 196194 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit daadd9f012a2c401ca1c605c43edb0707c60b75c, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.03	0.03
query3	0.24	0.08	0.06
query4	1.61	0.11	0.10
query5	0.44	0.42	0.42
query6	1.15	0.65	0.65
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.59	0.49	0.49
query10	0.55	0.56	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.62	0.58
query14	2.82	2.79	2.87
query15	0.89	0.84	0.81
query16	0.37	0.36	0.36
query17	1.04	0.97	1.00
query18	0.21	0.22	0.21
query19	1.89	1.86	2.00
query20	0.02	0.01	0.01
query21	15.36	0.61	0.57
query22	2.72	2.75	1.56
query23	17.08	0.91	0.77
query24	3.21	1.19	1.51
query25	0.14	0.19	0.08
query26	0.53	0.14	0.14
query27	0.05	0.05	0.04
query28	10.19	1.11	1.07
query29	12.63	3.26	3.22
query30	0.24	0.06	0.06
query31	2.87	0.38	0.37
query32	3.25	0.47	0.46
query33	3.09	3.18	3.06
query34	16.99	4.52	4.47
query35	4.60	4.46	4.52
query36	0.68	0.47	0.50
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.12	0.12
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107 s
Total hot run time: 32.47 s

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li Jibing-Li merged commit 6403b3c into apache:master Dec 23, 2024
30 of 31 checks passed
@Jibing-Li Jibing-Li deleted the auditlog branch December 23, 2024 09:07
Jibing-Li added a commit that referenced this pull request Dec 23, 2024
Jibing-Li added a commit that referenced this pull request Dec 23, 2024
@wm1581066 wm1581066 added the usercase Important user case type label label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants