Migrate user_defined tests to insta (#15255)

* migrate user_defined tests to insta

* fix tests

* test

* fmt

* update snaps

* add snaps

* add snaps

* add inline snapshots

* fix

* remove snaps

* Reuse batches_to_stirng

---------

Co-authored-by: Andrew Lamb <[email protected]>

Author: shruti2522

datafusion/core/tests/user_defined/expr_planner.rs

@@ -16,9 +16,10 @@
 // under the License.
 
 use arrow::array::RecordBatch;
+use datafusion::common::test_util::batches_to_string;
 use std::sync::Arc;
 
-use datafusion::common::{assert_batches_eq, DFSchema};
+use datafusion::common::DFSchema;
 use datafusion::error::Result;
 use datafusion::execution::FunctionRegistry;
 use datafusion::logical_expr::Operator;
@@ -76,49 +77,51 @@ async fn plan_and_collect(sql: &str) -> Result<Vec<RecordBatch>> {
 #[tokio::test]
 async fn test_custom_operators_arrow() {
     let actual = plan_and_collect("select 'foo'->'bar';").await.unwrap();
-    let expected = [
-        "+----------------------------+",
-        "| Utf8(\"foo\") || Utf8(\"bar\") |",
-        "+----------------------------+",
-        "| foobar                     |",
-        "+----------------------------+",
-    ];
-    assert_batches_eq!(&expected, &actual);
+    insta::assert_snapshot!(batches_to_string(&actual), @r###"
+    +----------------------------+
+    | Utf8("foo") || Utf8("bar") |
+    +----------------------------+
+    | foobar                     |
+    +----------------------------+
+    "###);
 }
 
 #[tokio::test]
 async fn test_custom_operators_long_arrow() {
     let actual = plan_and_collect("select 1->>2;").await.unwrap();
-    let expected = [
-        "+---------------------+",
-        "| Int64(1) + Int64(2) |",
-        "+---------------------+",
-        "| 3                   |",
-        "+---------------------+",
-    ];
-    assert_batches_eq!(&expected, &actual);
+    insta::assert_snapshot!(batches_to_string(&actual), @r###"
+    +---------------------+
+    | Int64(1) + Int64(2) |
+    +---------------------+
+    | 3                   |
+    +---------------------+
+    "###);
 }
 
 #[tokio::test]
 async fn test_question_select() {
     let actual = plan_and_collect("select a ? 2 from (select 1 as a);")
         .await
         .unwrap();
-    let expected = [
-        "+--------------+",
-        "| a ? Int64(2) |",
-        "+--------------+",
-        "| true         |",
-        "+--------------+",
-    ];
-    assert_batches_eq!(&expected, &actual);
+    insta::assert_snapshot!(batches_to_string(&actual), @r###"
+    +--------------+
+    | a ? Int64(2) |
+    +--------------+
+    | true         |
+    +--------------+
+    "###);
 }
 
 #[tokio::test]
 async fn test_question_filter() {
     let actual = plan_and_collect("select a from (select 1 as a) where a ? 2;")
         .await
         .unwrap();
-    let expected = ["+---+", "| a |", "+---+", "| 1 |", "+---+"];
-    assert_batches_eq!(&expected, &actual);
+    insta::assert_snapshot!(batches_to_string(&actual), @r###"
+    +---+
+    | a |
+    +---+
+    | 1 |
+    +---+
+    "###);
 }