Skip to content

Commit 08d730a

Browse files
committed
feat: add comments to Q27 and Q28 query copies for byte-length semantics clarification
- Updated comments in the following files: - benchmarks/queries/clickbench/queries/q27.sql - benchmarks/queries/clickbench/queries/q28.sql - benchmarks/sql_benchmarks/clickbench/benchmarks/q27.benchmark - benchmarks/sql_benchmarks/clickbench/benchmarks/q28.benchmark - Added note: "DataFusion length(...) counts characters; use octet_length(...) for ClickBench byte-length semantics."
1 parent 420c306 commit 08d730a

4 files changed

Lines changed: 4 additions & 0 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
-- Must set for ClickBench hits_partitioned dataset. See https://github.com/apache/datafusion/issues/16591
22
-- set datafusion.execution.parquet.binary_as_string = true
33

4+
-- DataFusion length(...) counts characters; use octet_length(...) for ClickBench byte-length semantics.
45
SELECT "CounterID", AVG(octet_length("URL")) AS l, COUNT(*) AS c FROM hits WHERE "URL" <> '' GROUP BY "CounterID" HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25;
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
-- Must set for ClickBench hits_partitioned dataset. See https://github.com/apache/datafusion/issues/16591
22
-- set datafusion.execution.parquet.binary_as_string = true
33

4+
-- DataFusion length(...) counts characters; use octet_length(...) for ClickBench byte-length semantics.
45
SELECT REGEXP_REPLACE("Referer", '^https?://(?:www\.)?([^/]+)/.*$', '\1') AS k, AVG(octet_length("Referer")) AS l, COUNT(*) AS c, MIN("Referer") FROM hits WHERE "Referer" <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25;

benchmarks/sql_benchmarks/clickbench/benchmarks/q27.benchmark

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ SELECT COUNT(*) > 0 from hits;
1111
true
1212

1313
run
14+
-- DataFusion length(...) counts characters; use octet_length(...) for ClickBench byte-length semantics.
1415
SELECT "CounterID", AVG(octet_length("URL")) AS l, COUNT(*) AS c FROM hits WHERE "URL" <> '' GROUP BY "CounterID" HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25;
1516

1617
result sql_benchmarks/clickbench/results/${CLICKBENCH_TYPE:-single}/q27.csv

benchmarks/sql_benchmarks/clickbench/benchmarks/q28.benchmark

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ SELECT COUNT(*) > 0 from hits;
1111
true
1212

1313
run
14+
-- DataFusion length(...) counts characters; use octet_length(...) for ClickBench byte-length semantics.
1415
SELECT REGEXP_REPLACE("Referer", '^https?://(?:www\.)?([^/]+)/.*$', '\1') AS k, AVG(octet_length("Referer")) AS l, COUNT(*) AS c, MIN("Referer") FROM hits WHERE "Referer" <> '' GROUP BY k HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT 25;
1516

1617
result sql_benchmarks/clickbench/results/${CLICKBENCH_TYPE:-single}/q28.csv

0 commit comments

Comments
 (0)