Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move postgres specfiic code into postgres dialect #22

Open
andygrove opened this issue Oct 6, 2018 · 1 comment
Open

Move postgres specfiic code into postgres dialect #22

andygrove opened this issue Oct 6, 2018 · 1 comment
Milestone
Milestone 1 - Bas...

Comments

@andygrove
Copy link
Member

The recent PR for postgres support has led to postgres specific parsing and writing code creeping into the base sqlparser module. We need to move the postgres specific code into the postgres dialect module.
@andygrove andygrove added this to the Milestone 1 milestone Oct 6, 2018
@nickolay
Copy link
Contributor

nickolay commented Mar 6, 2019

Hey @andygrove, until #7 is resolved would you be OK with accepting additional dialect-specific code in the generic parser? I'm asking because @benesch has just submitted a PR to support CREATE MATERIALIZED VIEW (nickolay#1) against my fork of sqlparser-rs. Since I intend to get my fork merged into the mainline, I thought I'd ask now rather than later...

serprex added a commit to serprex/sqlparser-rs that referenced this issue Nov 6, 2023
@serprex
Allow mappings to specify from/to/key in any order (apache#22)
1a619fd 
Improves UX while preparing for addition of another optional field for column exclusion
jmhain pushed a commit to jmhain/sqlparser-rs that referenced this issue Jul 14, 2024
@HiranmayaGundu
feat: implement wildcard select ilike (apache#22)
9889b24 
Implements parsing for `SELECT * ILIKE ...` which is valid syntax in
snowflake: https://docs.snowflake.com/en/sql-reference/sql/select

Via googling, it seems like only snowflake supports this syntax. I could
not find any other dialect that does. Snowflake does not allow `SELECT *
ILIKE <pattern> EXCLUDE <column>` so I implemented that as well.
jmhain added a commit to jmhain/sqlparser-rs that referenced this issue Jul 14, 2024
@jmhain
Revert "feat: implement wildcard select ilike (apache#22)"
d304c23 
This reverts commit 9889b24, reversing
changes made to 16cdc92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 1 - Basic Design
Development

No branches or pull requests
2 participants
@nickolay @andygrove