Parse Postgres VARBIT datatype (#1703)

apache · Feb 8, 2025 · cad4923 · cad4923
1 parent 86abbd6
commit cad4923
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 1 deletion.
diff --git a/src/ast/data_type.rs b/src/ast/data_type.rs
@@ -328,10 +328,15 @@ pub enum DataType {
     /// [MySQL]: https://dev.mysql.com/doc/refman/9.1/en/bit-type.html
     /// [MSSQL]: https://learn.microsoft.com/en-us/sql/t-sql/data-types/bit-transact-sql?view=sql-server-ver16
     Bit(Option<u64>),
-    /// Variable-length bit string e.g. [Postgres]
+    /// `BIT VARYING(n)`: Variable-length bit string e.g. [Postgres]
     ///
     /// [Postgres]: https://www.postgresql.org/docs/current/datatype-bit.html
     BitVarying(Option<u64>),
+    /// `VARBIT(n)`: Variable-length bit string. [Postgres] alias for `BIT VARYING`
+    ///
+    /// [Postgres]: https://www.postgresql.org/docs/current/datatype.html
+    VarBit(Option<u64>),
+    ///
     /// Custom type such as enums
     Custom(ObjectName, Vec<String>),
     /// Arrays
@@ -550,6 +555,7 @@ impl fmt::Display for DataType {
             DataType::BitVarying(size) => {
                 format_type_with_optional_length(f, "BIT VARYING", size, false)
             }
+            DataType::VarBit(size) => format_type_with_optional_length(f, "VARBIT", size, false),
             DataType::Array(ty) => match ty {
                 ArrayElemTypeDef::None => write!(f, "ARRAY"),
                 ArrayElemTypeDef::SquareBracket(t, None) => write!(f, "{t}[]"),

diff --git a/src/keywords.rs b/src/keywords.rs
@@ -925,6 +925,7 @@ define_keywords!(
     VALUES,
     VALUE_OF,
     VARBINARY,
+    VARBIT,
     VARCHAR,
     VARIABLES,
     VARYING,

diff --git a/src/parser/mod.rs b/src/parser/mod.rs
@@ -8779,6 +8779,7 @@ impl<'a> Parser<'a> {
                         Ok(DataType::Bit(self.parse_optional_precision()?))
                     }
                 }
+                Keyword::VARBIT => Ok(DataType::VarBit(self.parse_optional_precision()?)),
                 Keyword::UUID => Ok(DataType::Uuid),
                 Keyword::DATE => Ok(DataType::Date),
                 Keyword::DATE32 => Ok(DataType::Date32),

diff --git a/tests/sqlparser_postgres.rs b/tests/sqlparser_postgres.rs
@@ -5327,3 +5327,29 @@ fn parse_bitstring_literal() {
         ))]
     );
 }
+
+#[test]
+fn parse_varbit_datatype() {
+    match pg_and_generic().verified_stmt("CREATE TABLE foo (x VARBIT, y VARBIT(42))") {
+        Statement::CreateTable(CreateTable { columns, .. }) => {
+            assert_eq!(
+                columns,
+                vec![
+                    ColumnDef {
+                        name: "x".into(),
+                        data_type: DataType::VarBit(None),
+                        collation: None,
+                        options: vec![],
+                    },
+                    ColumnDef {
+                        name: "y".into(),
+                        data_type: DataType::VarBit(Some(42)),
+                        collation: None,
+                        options: vec![],
+                    }
+                ]
+            );
+        }
+        _ => unreachable!(),
+    }
+}