Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate to native code for cast_is_supported #1171

Closed
andygrove opened this issue Dec 13, 2024 · 1 comment
Closed

Delegate to native code for cast_is_supported #1171

andygrove opened this issue Dec 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

PR #1169 re-implements the logic for determining which casts are supported by Spark/Comet in native code because it is now needed when reading from ParquetExec.

This means that we have the same code implemented both in Scala and native code.

Describe the potential solution

Perhaps we can have the Scala code call the native code via JNI rather than maintain two copies.

Additional context

No response

@andygrove
Copy link
Member Author

The native code mentioned above is now specific to parquet-to-spark conversion, so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant