Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkCastOptions should represent timezone as Option<Tz> instead of String #1147

Open
andygrove opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

andygrove commented Dec 6, 2024

What is the problem the feature request solves?

In Comet's native cast logic, we currently pass timezones around as strings and use empty strings to represent lack of timezones. This results in repeated parsing of timestamps that could be avoided.

Describe the potential solution

Change timezone from String to Option<Tz>

Additional context

See SparkCastOptions, added in #1146.

@andygrove andygrove added enhancement New feature or request help wanted Extra attention is needed labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant