Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "INFO" log level #1127

Closed
SalcaE opened this issue Nov 29, 2024 · 5 comments
Closed

Missing "INFO" log level #1127

SalcaE opened this issue Nov 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SalcaE
Copy link

SalcaE commented Nov 29, 2024

Describe the bug

I'm running Comet 0.4.0 and I can't see the log level info to check if Comet is enabled for Spark SQL query, which I was able to do with version 0.3.0.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response

@SalcaE SalcaE added the bug Something isn't working label Nov 29, 2024
@andygrove
Copy link
Member

I also noticed this recently. Thanks for filing the issue.

@andygrove andygrove added this to the 0.5.0 milestone Dec 2, 2024
@andygrove
Copy link
Member

Here is my repro.

Comet 0.3.0

scala> spark.read.parquet("/mnt/bigdata/tpch/sf100/lineitem.parquet").createTempView("lineitem")
25/01/08 13:56:35 INFO core/src/lib.rs: Comet native library version 0.3.0 initialized
25/01/08 13:56:35 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging):
 Execute CreateViewCommand [COMET: Execute CreateViewCommand is not supported]
   +- CreateViewCommand
         +- LogicalRelation


scala> spark.sql("select cast(l_shipmode as decimal(12,2)) from lineitem").show
25/01/08 13:56:40 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging):
 CollectLimit [COMET: CollectLimit is not supported]
+-  Project [COMET: Comet does not guarantee correct results for cast from StringType to DecimalType(12,2) with timezone Some(America/Denver) and evalMode LEGACY (Does not support inputs ending with 'd' or 'f'. Does not support 'inf'. Does not support ANSI mode. Returns 0.0 instead of null if input contains no digits). To enable all incompatible casts, set spark.comet.cast.allowIncompatible=true]
   +- CometScanWrapper

+----------+
|l_shipmode|
+----------+
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
+----------+
only showing top 20 rows

Comet 0.4.0

scala> spark.read.parquet("/mnt/bigdata/tpch/sf100/lineitem.parquet").createTempView("lineitem")
25/01/08 13:57:31 INFO core/src/lib.rs: Comet native library version 0.4.0 initialized

scala> spark.sql("select cast(l_shipmode as decimal(12,2)) from lineitem").show
+----------+
|l_shipmode|
+----------+
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
|      null|
+----------+
only showing top 20 rows

@andygrove andygrove self-assigned this Jan 8, 2025
@andygrove
Copy link
Member

I do not see the issue when I build the latest from the main branch.

@andygrove
Copy link
Member

I could reproduce the issue when building from the 0.4.0 tag, but I do see the logging when I enable off-heap memory so the issue appears to be that we were silently disabling the plugin in 0.4.0 when off-heap was disabled.

@andygrove
Copy link
Member

I am going to go ahead and close this since we no longer require off-heap to be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants