Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Trusted Signing Support #281

Open
OPSnake opened this issue Feb 19, 2025 · 0 comments
Open

Add Azure Trusted Signing Support #281

OPSnake opened this issue Feb 19, 2025 · 0 comments

Comments

@OPSnake
Copy link

OPSnake commented Feb 19, 2025

Feature Request

Motivation Behind Feature

To improve security and simplify the build workflow, it is essential to integrate support for Azure Trusted Signing into cordova-electron. Since electron-builder already supports this feature, cordova-electron should simply pass the configuration options to electron-builder. This will allow developers to easily enable Azure signing without having to manage additional configurations or external scripts

Feature Description

The goal is to add a new configuration section in build.json, for example azureSignOptions, which will be recognized by cordova-electron and passed directly to electron-builder during the build process. The proposed configuration is as follows:

{
  "electron": {
    "windows": {
      "azureSignOptions": {
        "endpoint": "<Trusted Signing account endpoint>",
        "publisherName": "<Publisher name>",
        "certificateProfileName": "<Certificate profile name>",
        "codeSigningAccountName": "<Trusted Signing account name>"
      }
    }
  }
}

The expected behavior is as follows:

Configuration Retrieval: Cordova-electron should read the azureSignOptions present in the configuration file (e.g., build.json).
Transmission to electron-builder: These options should be passed to electron-builder, which will then use these parameters to sign the application via Azure Trusted Signing.

Alternatives or Workarounds

Currently, developers must either manually modify electron-builder’s configuration or use external scripts to integrate Azure Trusted Signing after the build. This approach increases complexity and the risk of errors. By centralizing this configuration in cordova-electron and automatically passing it to electron-builder, the process becomes simpler and less error-prone, providing a better user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant