Add safe checks and make sure log4j configuration has log4j2 format

Author: harikrishna-patnala

debian/cloudstack-management.postinst

@@ -62,6 +62,34 @@ if [ "$1" = configure ]; then
     chmod -R 0755 /etc/cloudstack/extensions
     chown -R cloud:cloud /etc/cloudstack/extensions
 
+    LOGFILE="${CONFDIR}/log4j-cloud.xml"
+
+    # Detect if current file is old Log4j1 format
+    if grep -q "<log4j:configuration" "$LOGFILE" 2>/dev/null; then
+        echo "Old Log4j1 format detected in $LOGFILE"
+
+        BACKUP_SUFFIXES=".rpmnew .dpkg-new .dpkg-dist"
+        for sfx in $BACKUP_SUFFIXES; do
+            NEWFILE="${LOGFILE}${sfx}"
+            if [ -f "$NEWFILE" ]; then
+                echo "Found new version candidate: $NEWFILE"
+
+                # Verify that the candidate actually has Log4j2 syntax
+                if grep -q "<Configuration" "$NEWFILE" 2>/dev/null; then
+                    echo "Verified Log4j2 format in $NEWFILE — applying update."
+                    cp -f "$NEWFILE" "$LOGFILE"
+                    mv "$NEWFILE" "${NEWFILE}.bak.$(date +%F_%H-%M-%S)"
+                    echo "Replaced old Log4j1 config with Log4j2 version."
+                    break
+                else
+                    echo "WARNING: $NEWFILE does not appear to be Log4j2 format — skipping."
+                fi
+            fi
+        done
+    else
+        echo "Log4j2 format already present — no action needed."
+    fi
+
     ln -sf ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j2.xml
 
     # Add jdbc MySQL driver settings to db.properties if not present

debian/cloudstack-management.preinst

@@ -29,4 +29,14 @@ if [ "$1" = upgrade ]; then
         rm -f /usr/share/cloudstack-management/work
         rm -f /etc/default/cloudstack-management
     fi
+
+    if [ -L "/etc/cloudstack/management/log4j.xml" ]; then
+        echo "Removing existing /etc/cloudstack/management/log4j.xml, symlink will again be created during post install"
+        rm -f /etc/cloudstack/management/log4j.xml
+    fi
+
+    if [ -L "/etc/cloudstack/management/log4j2.xml" ]; then
+        echo "Removing existing /etc/cloudstack/management/log4j2.xml, symlink will again be created during post install"
+        rm -f /etc/cloudstack/management/log4j2.xml
+    fi
 fi