test: add comprehensive unit tests for L2/L3 network validation

- Add TestResourceCloudStackNetworkSchema to validate schema structure
- Add TestParseCIDR to test CIDR parsing logic for both L2 and L3 networks
- Verify L2 networks return empty CIDR parsing results
- Verify L3 networks require CIDR and parse correctly
- All tests pass, ensuring functionality works as expected

Author: sidshas03

cloudstack/resource_cloudstack_network_parse_test.go

@@ -0,0 +1,69 @@
+package cloudstack
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func TestParseCIDR(t *testing.T) {
+	networkResource := resourceCloudStackNetwork()
+	
+	t.Run("L2 network should return empty map", func(t *testing.T) {
+		config := map[string]interface{}{
+			"type": "L2",
+		}
+		
+		resourceData := schema.TestResourceDataRaw(t, networkResource.Schema, config)
+		
+		result, err := parseCIDR(resourceData, false)
+		if err != nil {
+			t.Errorf("Expected no error for L2 network, got: %v", err)
+		}
+		if result == nil {
+			t.Error("Expected non-nil result for L2 network")
+		}
+		if len(result) != 0 {
+			t.Errorf("Expected empty map for L2 network, got: %v", result)
+		}
+	})
+	
+	t.Run("L3 network with valid CIDR should parse correctly", func(t *testing.T) {
+		config := map[string]interface{}{
+			"type": "L3",
+			"cidr": "10.0.0.0/16",
+		}
+		
+		resourceData := schema.TestResourceDataRaw(t, networkResource.Schema, config)
+		
+		result, err := parseCIDR(resourceData, true)
+		if err != nil {
+			t.Errorf("Expected no error for L3 network with valid CIDR, got: %v", err)
+		}
+		if result == nil {
+			t.Error("Expected non-nil result for L3 network")
+		}
+		if result["gateway"] == "" {
+			t.Error("Expected gateway to be set")
+		}
+		if result["netmask"] == "" {
+			t.Error("Expected netmask to be set")
+		}
+	})
+	
+	t.Run("L3 network without CIDR should return error", func(t *testing.T) {
+		config := map[string]interface{}{
+			"type": "L3",
+		}
+		
+		resourceData := schema.TestResourceDataRaw(t, networkResource.Schema, config)
+		
+		_, err := parseCIDR(resourceData, true)
+		if err == nil {
+			t.Error("Expected error for L3 network without CIDR, but got none")
+		}
+		if err != nil && err.Error() != "cidr is required for L3 networks" {
+			t.Errorf("Expected specific error message, got: %v", err)
+		}
+	})
+}

cloudstack/resource_cloudstack_network_validation_test.go

@@ -0,0 +1,50 @@
+package cloudstack
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func TestResourceCloudStackNetworkSchema(t *testing.T) {
+	networkResource := resourceCloudStackNetwork()
+	
+	// Test that required fields exist
+	t.Run("Schema should have type field", func(t *testing.T) {
+		if typeField, ok := networkResource.Schema["type"]; !ok {
+			t.Error("Schema should have 'type' field")
+		} else {
+			if typeField.Type != schema.TypeString {
+				t.Errorf("Type field should be TypeString, got: %v", typeField.Type)
+			}
+			if typeField.Required {
+				t.Error("Type field should not be required")
+			}
+			if typeField.Optional != true {
+				t.Error("Type field should be optional")
+			}
+			if typeField.Default != "L3" {
+				t.Errorf("Type field default should be 'L3', got: %v", typeField.Default)
+			}
+		}
+	})
+	
+	t.Run("Schema should have cidr field as optional", func(t *testing.T) {
+		if cidrField, ok := networkResource.Schema["cidr"]; !ok {
+			t.Error("Schema should have 'cidr' field")
+		} else {
+			if cidrField.Required {
+				t.Error("CIDR field should not be required")
+			}
+			if cidrField.Optional != true {
+				t.Error("CIDR field should be optional")
+			}
+		}
+	})
+	
+	t.Run("Schema should have CustomizeDiff", func(t *testing.T) {
+		if networkResource.CustomizeDiff == nil {
+			t.Error("Resource should have CustomizeDiff function")
+		}
+	})
+}