Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21484: mp-config should not be loadable as it has overhead at r… #16661

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

davsclaus
Copy link
Contributor

…untime

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@Paul-Blanchaert
Copy link
Contributor

@davsclaus
I believe we still require the method isValidForActiveProfiles(String name). This filters the "active" properties for the selected runtime profile(s). That might be the reason why the "loadable" was chosen in the first place.
CAMEL-21480 is expected to enhance this isValidForActiveProfiles(String name) method to support for multiple profiles.

@Paul-Blanchaert
Copy link
Contributor

Paul-Blanchaert commented Dec 27, 2024

On 2nd thought: probably that CAMEL-21480 is also sorted by using the service as it delegates that function to the service...
Can we add some tests to validate that? I'm happy to help with that.

@jamesnetherton
Copy link
Contributor

I believe we still require the method isValidForActiveProfiles(String name). This filters the "active" properties for the selected runtime profile(s

I don't think that's needed with this change. If we're just resolving properties at runtime via ConfigProvider, then it'll factor in whatever active profiles are enabled.

@davsclaus davsclaus merged commit 3adff53 into main Dec 28, 2024
5 checks passed
@davsclaus davsclaus deleted the mploc branch December 28, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants