From 80ca9f1e868d9c1ac8c4e94234951c74efd7f43f Mon Sep 17 00:00:00 2001 From: huangguojie2024 <503601315@qq.com> Date: Fri, 7 Feb 2025 17:32:46 +0800 Subject: [PATCH 1/5] Add some unit tests for stack extra module. --- .../seatunnel/SeaTunnelClientScriptTest.java | 49 +++++++++++++++ .../seatunnel/SeaTunnelMasterScriptTest.java | 34 +++++++++++ .../v1_0_0/seatunnel/SeaTunnelParamsTest.java | 60 +++++++++++++++++++ .../seatunnel/SeaTunnelWorkerScriptTest.java | 34 +++++++++++ 4 files changed, 177 insertions(+) create mode 100644 bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java create mode 100644 bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java create mode 100644 bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java create mode 100644 bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java new file mode 100644 index 000000000..e8fceca8c --- /dev/null +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; + +import org.apache.bigtop.manager.stack.core.spi.param.Params; +import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelClientScript; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; + +public class SeaTunnelClientScriptTest { + + private final SeaTunnelClientScript clientScript = new SeaTunnelClientScript(); + + @Test + public void testGetComponentName() { + assertEquals("seatunnel_client", clientScript.getComponentName()); + } + + @Test + public void testAddParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> clientScript.add(params)); + } + + @Test + public void testConfigureParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> clientScript.configure(params)); + } +} diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java new file mode 100644 index 000000000..f6eadeb5c --- /dev/null +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; + +import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelMasterScript; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class SeaTunnelMasterScriptTest { + + @Test + public void testGetComponentName() { + SeaTunnelMasterScript script = new SeaTunnelMasterScript(); + assertEquals("seatunnel_master", script.getComponentName()); + } +} diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java new file mode 100644 index 000000000..4ef76ec2e --- /dev/null +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; + +import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelParams; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class SeaTunnelParamsTest { + + @Test + public void testConfDir() { + SeaTunnelParams seaTunnelParams = mock(SeaTunnelParams.class); + when(seaTunnelParams.serviceHome()).thenReturn("/bigtop/seatunnel"); + when(seaTunnelParams.confDir()).thenCallRealMethod(); + assertEquals("/bigtop/seatunnel/config", seaTunnelParams.confDir()); + } + + @Test + public void testSparkHome() { + SeaTunnelParams seaTunnelParams = mock(SeaTunnelParams.class); + when(seaTunnelParams.stackHome()).thenReturn("/stack"); + when(seaTunnelParams.sparkHome()).thenCallRealMethod(); + assertEquals("/stack/spark", seaTunnelParams.sparkHome()); + } + + @Test + public void testFlinkHome() { + SeaTunnelParams seaTunnelParams = mock(SeaTunnelParams.class); + when(seaTunnelParams.stackHome()).thenReturn("/stack"); + when(seaTunnelParams.flinkHome()).thenCallRealMethod(); + assertEquals("/stack/flink", seaTunnelParams.flinkHome()); + } + + @Test + public void testGetServiceName() { + SeaTunnelParams seaTunnelParams = new SeaTunnelParams(); + assertEquals("seatunnel", seaTunnelParams.getServiceName()); + } +} diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java new file mode 100644 index 000000000..d8c93034c --- /dev/null +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; + +import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelWorkerScript; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class SeaTunnelWorkerScriptTest { + + @Test + public void testGetComponentName() { + SeaTunnelWorkerScript workerScript = new SeaTunnelWorkerScript(); + assertEquals("seatunnel_worker", workerScript.getComponentName()); + } +} From cb37028068a8a57b0c550a3f1f6d73f16df0d138 Mon Sep 17 00:00:00 2001 From: huangguojie2024 <503601315@qq.com> Date: Sun, 9 Feb 2025 00:29:04 +0800 Subject: [PATCH 2/5] Fix the package name. --- .../stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java | 2 +- .../stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java | 2 +- .../stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java | 2 +- .../stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) rename bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/{rg => org}/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java (96%) rename bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/{rg => org}/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java (95%) rename bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/{rg => org}/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java (97%) rename bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/{rg => org}/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java (95%) diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java similarity index 96% rename from bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java rename to bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java index e8fceca8c..25c8e473e 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; import org.apache.bigtop.manager.stack.core.spi.param.Params; import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelClientScript; diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java similarity index 95% rename from bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java rename to bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java index f6eadeb5c..948b5f730 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelMasterScript; diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java similarity index 97% rename from bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java rename to bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java index 4ef76ec2e..73a4432d8 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelParams; diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java similarity index 95% rename from bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java rename to bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java index d8c93034c..6f0bef796 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/rg/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java @@ -16,7 +16,7 @@ * specific language governing permissions and limitations * under the License. */ -package rg.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelWorkerScript; From e07e8a962f40e88888b1fe5babac94679ddf9115 Mon Sep 17 00:00:00 2001 From: huangguojie2024 <503601315@qq.com> Date: Sun, 9 Feb 2025 11:23:23 +0800 Subject: [PATCH 3/5] Fix the code style. --- .../stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java | 1 - .../stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java | 2 -- .../stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java | 2 -- .../stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java | 2 -- 4 files changed, 7 deletions(-) diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java index 25c8e473e..439f3bebc 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelClientScriptTest.java @@ -19,7 +19,6 @@ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; import org.apache.bigtop.manager.stack.core.spi.param.Params; -import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelClientScript; import org.junit.jupiter.api.Test; diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java index 948b5f730..d28baf276 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java @@ -18,8 +18,6 @@ */ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; -import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelMasterScript; - import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java index 73a4432d8..8ab11a7cc 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java @@ -18,8 +18,6 @@ */ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; -import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelParams; - import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java index 6f0bef796..82f5f70dc 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java @@ -18,8 +18,6 @@ */ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; -import org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel.SeaTunnelWorkerScript; - import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; From faed8b96d3fda1898df8a46fd0309fc28500e6d0 Mon Sep 17 00:00:00 2001 From: huangguojie2024 <503601315@qq.com> Date: Mon, 10 Feb 2025 14:10:02 +0800 Subject: [PATCH 4/5] Fix the code style. --- .../v1_0_0/seatunnel/SeaTunnelParamsTest.java | 31 ++++++++++++------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java index 8ab11a7cc..d6194c7d9 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelParamsTest.java @@ -18,6 +18,7 @@ */ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -26,33 +27,41 @@ public class SeaTunnelParamsTest { + private SeaTunnelParams seaTunnelParams; + + @BeforeEach + public void setUp() { + seaTunnelParams = mock(SeaTunnelParams.class); + when(seaTunnelParams.stackHome()).thenReturn("/stack"); + when(seaTunnelParams.getServiceName()).thenCallRealMethod(); + when(seaTunnelParams.serviceHome()).thenCallRealMethod(); + when(seaTunnelParams.sparkHome()).thenCallRealMethod(); + when(seaTunnelParams.flinkHome()).thenCallRealMethod(); + when(seaTunnelParams.confDir()).thenCallRealMethod(); + } + + @Test + public void testServiceHome() { + assertEquals("/stack/seatunnel", seaTunnelParams.serviceHome()); + } + @Test public void testConfDir() { - SeaTunnelParams seaTunnelParams = mock(SeaTunnelParams.class); - when(seaTunnelParams.serviceHome()).thenReturn("/bigtop/seatunnel"); - when(seaTunnelParams.confDir()).thenCallRealMethod(); - assertEquals("/bigtop/seatunnel/config", seaTunnelParams.confDir()); + assertEquals("/stack/seatunnel/config", seaTunnelParams.confDir()); } @Test public void testSparkHome() { - SeaTunnelParams seaTunnelParams = mock(SeaTunnelParams.class); - when(seaTunnelParams.stackHome()).thenReturn("/stack"); - when(seaTunnelParams.sparkHome()).thenCallRealMethod(); assertEquals("/stack/spark", seaTunnelParams.sparkHome()); } @Test public void testFlinkHome() { - SeaTunnelParams seaTunnelParams = mock(SeaTunnelParams.class); - when(seaTunnelParams.stackHome()).thenReturn("/stack"); - when(seaTunnelParams.flinkHome()).thenCallRealMethod(); assertEquals("/stack/flink", seaTunnelParams.flinkHome()); } @Test public void testGetServiceName() { - SeaTunnelParams seaTunnelParams = new SeaTunnelParams(); assertEquals("seatunnel", seaTunnelParams.getServiceName()); } } From 11433bb5db3fd2858c28b1faf48ba813dc4d0215 Mon Sep 17 00:00:00 2001 From: huangguojie2024 <503601315@qq.com> Date: Tue, 11 Feb 2025 20:11:13 +0800 Subject: [PATCH 5/5] Add some ut cases. --- .../seatunnel/SeaTunnelMasterScriptTest.java | 38 ++++++++++++++++++- .../seatunnel/SeaTunnelWorkerScriptTest.java | 38 ++++++++++++++++++- 2 files changed, 72 insertions(+), 4 deletions(-) diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java index d28baf276..09e1a0ca3 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelMasterScriptTest.java @@ -18,15 +18,49 @@ */ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +import org.apache.bigtop.manager.stack.core.spi.param.Params; + import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; public class SeaTunnelMasterScriptTest { + private final SeaTunnelMasterScript seaTunnelMasterScript = new SeaTunnelMasterScript(); + @Test public void testGetComponentName() { - SeaTunnelMasterScript script = new SeaTunnelMasterScript(); - assertEquals("seatunnel_master", script.getComponentName()); + assertEquals("seatunnel_master", seaTunnelMasterScript.getComponentName()); + } + + @Test + public void testAddParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelMasterScript.add(params)); + } + + @Test + public void testConfigureParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelMasterScript.configure(params)); + } + + @Test + public void testStartParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelMasterScript.start(params)); + } + + @Test + public void testStopParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelMasterScript.stop(params)); + } + + @Test + public void testStatusParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelMasterScript.status(params)); } } diff --git a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java index 82f5f70dc..0cc54c7d5 100644 --- a/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java +++ b/bigtop-manager-stack/bigtop-manager-stack-extra/src/test/java/org/apache/bigtop/manager/stack/extra/v1_0_0/seatunnel/SeaTunnelWorkerScriptTest.java @@ -18,15 +18,49 @@ */ package org.apache.bigtop.manager.stack.extra.v1_0_0.seatunnel; +import org.apache.bigtop.manager.stack.core.spi.param.Params; + import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; public class SeaTunnelWorkerScriptTest { + private final SeaTunnelWorkerScript seaTunnelWorkerScript = new SeaTunnelWorkerScript(); + @Test public void testGetComponentName() { - SeaTunnelWorkerScript workerScript = new SeaTunnelWorkerScript(); - assertEquals("seatunnel_worker", workerScript.getComponentName()); + assertEquals("seatunnel_worker", seaTunnelWorkerScript.getComponentName()); + } + + @Test + public void testAddParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelWorkerScript.add(params)); + } + + @Test + public void testConfigureParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelWorkerScript.configure(params)); + } + + @Test + public void testStartParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelWorkerScript.start(params)); + } + + @Test + public void testStopParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelWorkerScript.stop(params)); + } + + @Test + public void testStatusParamsNull() { + Params params = null; + assertThrows(NullPointerException.class, () -> seaTunnelWorkerScript.status(params)); } }