-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-48181: [C++] Use FetchContent for bundled Protobuf #48183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ELEMETRY_PROTOC_EXECUTABLE so it works with FetchContent targets too
|
@github-actions crossbow submit -g cpp |
|
Revision: b4901bf Submitted crossbow builds: ursacomputing/crossbow @ actions-92d482b371 |
|
@github-actions crossbow submit -g r |
|
Revision: b4901bf Submitted crossbow builds: ursacomputing/crossbow @ actions-3018e6ef2f |
|
@github-actions crossbow submit -g cpp -g r |
|
Revision: 7919c19 Submitted crossbow builds: ursacomputing/crossbow @ actions-f0723051de |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Co-authored-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a17e247. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
As a follow up of requiring a minimum CMake version >= 3.25 we discussed moving our dependencies from ExternalProject to FetchContent. This can simplify our third party dependency management. Moving Protobuf is the next step before moving gRPC.
What changes are included in this PR?
The general change is moving from
ExternalProjecttoFetchContent.It also add some required integration due to other dependencies, like gRPC, using
ExternalProject. We not only have to build but also install in order for those other dependencies to find Protobuf. This causes some timing issues between config, build, install that requires us to create a custom target to depend on so the other dependencies find Protobuf.Are these changes tested?
Yes, the changes are tested locally and on CI.
Are there any user-facing changes?
No