Suppress warnings in GLib

Author: tadeja

c_glib/arrow-glib/reader.cpp

@@ -781,7 +781,9 @@ GArrowFeatherFileReader *
 garrow_feather_file_reader_new(GArrowSeekableInputStream *file, GError **error)
 {
   auto arrow_random_access_file = garrow_seekable_input_stream_get_raw(file);
+  ARROW_SUPPRESS_DEPRECATION_WARNING
   auto reader = arrow::ipc::feather::Reader::Open(arrow_random_access_file);
+  ARROW_UNSUPPRESS_DEPRECATION_WARNING
   if (garrow::check(error, reader, "[feather-file-reader][new]")) {
     return garrow_feather_file_reader_new_raw(&(*reader));
   } else {

c_glib/arrow-glib/table.cpp

@@ -772,6 +772,9 @@ garrow_table_validate_full(GArrowTable *table, GError **error)
   return garrow::check(error, arrow_table->ValidateFull(), "[table][validate-full]");
 }
 
+// The Feather C++ API is deprecated; this GLib binding still wraps it.
+ARROW_SUPPRESS_DEPRECATION_WARNING
+
 typedef struct GArrowFeatherWritePropertiesPrivate_
 {
   arrow::ipc::feather::WriteProperties properties;
@@ -932,6 +935,8 @@ garrow_table_write_as_feather(GArrowTable *table,
   return garrow::check(error, status, "[feather-write-file]");
 }
 
+ARROW_UNSUPPRESS_DEPRECATION_WARNING
+
 G_END_DECLS
 
 GArrowTable *
@@ -948,9 +953,11 @@ garrow_table_get_raw(GArrowTable *table)
   return priv->table;
 }
 
+ARROW_SUPPRESS_DEPRECATION_WARNING
 arrow::ipc::feather::WriteProperties *
 garrow_feather_write_properties_get_raw(GArrowFeatherWriteProperties *properties)
 {
   auto priv = GARROW_FEATHER_WRITE_PROPERTIES_GET_PRIVATE(properties);
   return &(priv->properties);
 }
+ARROW_UNSUPPRESS_DEPRECATION_WARNING

c_glib/arrow-glib/table.hpp

@@ -32,6 +32,8 @@ GARROW_EXTERN
 std::shared_ptr<arrow::Table>
 garrow_table_get_raw(GArrowTable *table);
 
+ARROW_SUPPRESS_DEPRECATION_WARNING
 GARROW_EXTERN
 arrow::ipc::feather::WriteProperties *
 garrow_feather_write_properties_get_raw(GArrowFeatherWriteProperties *properties);
+ARROW_UNSUPPRESS_DEPRECATION_WARNING

cpp/src/arrow/ipc/feather.h

@@ -117,7 +117,7 @@ class ARROW_EXPORT Reader {
 
 /// \deprecated Deprecated in 26.0.0. Feather V2 is the Arrow IPC file format;
 ///   use arrow::ipc::MakeFileWriter with arrow::ipc::IpcWriteOptions instead.
-struct ARROW_DEPRECATED("Deprecated in 26.0.0. Use arrow::ipc::MakeFileWriter instead.")
+struct ARROW_DEPRECATED("Deprecated in 26.0.0. Use arrow::ipc::IpcWriteOptions instead.")
     ARROW_EXPORT WriteProperties {
   static WriteProperties Defaults();
 

python/pyarrow/includes/libarrow_feather.pxd

@@ -23,8 +23,6 @@ from pyarrow.includes.libarrow cimport (CCompressionType, CStatus, CTable,
                                         c_string, CIpcReadOptions)
 
 
-# NOTE: these feather C++ APIs are deprecated; pyarrow still binds them.
-# The user-facing FutureWarning is in pyarrow/feather.py (GH-49232)
 cdef extern from "arrow/ipc/api.h" namespace "arrow::ipc" nogil:
     int kFeatherV1Version" arrow::ipc::feather::kFeatherV1Version"
     int kFeatherV2Version" arrow::ipc::feather::kFeatherV2Version"