Skip to content

Commit fa7ab48

Browse files
committed
More feedback
1 parent 97a98e8 commit fa7ab48

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

.github/workflows/cpp_extra.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,6 @@ jobs:
372372
persist-credentials: false
373373
fetch-depth: 0
374374
submodules: recursive
375-
- name: Create Docker Test Network
376-
run: docker network create odbc_net
377375
- name: Set Up Dremio Instance
378376
run: |
379377
docker compose up -d dremio

compose.yaml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,11 @@ x-hierarchy:
135135
- debian-ruby
136136
- debian-python:
137137
- debian-docs
138+
- dremio
138139
- fedora-cpp:
139140
- fedora-python
140141
- fedora-r-clang
141142
- python-sdist
142-
- dremio
143143
- ubuntu-cpp:
144144
- ubuntu-cpp-static
145145
- ubuntu-c-glib:
@@ -205,11 +205,6 @@ volumes:
205205
ubuntu-ccache:
206206
name: ${ARCH}-ubuntu-${UBUNTU}-ccache
207207

208-
networks:
209-
# GH-48068 for Flight SQL ODBC Testing
210-
odbc_net:
211-
external: true
212-
213208
services:
214209

215210
################################# C++ #######################################
@@ -392,8 +387,6 @@ services:
392387
interval: 10s
393388
timeout: 5s
394389
retries: 30
395-
networks:
396-
- odbc_net
397390

398391
ubuntu-cpp: &ubuntu-cpp-base
399392
# Usage:
@@ -542,8 +535,8 @@ services:
542535
ARROW_S3: "OFF"
543536
ARROW_SUBSTRAIT: "OFF"
544537
# Register ODBC before running tests
545-
networks:
546-
- odbc_net
538+
depends_on:
539+
- dremio
547540
command: >
548541
/bin/bash -c "
549542
/arrow/ci/scripts/cpp_build.sh /arrow /build &&

0 commit comments

Comments
 (0)