[C++] Address maintainer feedback on SimpleTable and fix macOS CI pkg-config error

Author: Alirana2829

.github/workflows/cpp.yml

@@ -228,7 +228,6 @@ jobs:
           # in GitHub Actions runner now. We can remove this once
           # pkg-config formula is removed from GitHub Actions runner.
           brew uninstall pkg-config || :
-          brew uninstall pkg-config@0.29.2 || :
           brew bundle --file=cpp/Brewfile
       - name: Install MinIO
         run: |

.github/workflows/python.yml

@@ -193,7 +193,6 @@ jobs:
           # in GitHub Actions runner now. We can remove this once
           # pkg-config formula is removed from GitHub Actions runner.
           brew uninstall pkg-config || :
-          brew uninstall pkg-config@0.29.2 || :
           brew bundle --file=cpp/Brewfile
 
           python -m pip install \

cpp/src/arrow/table.cc

@@ -63,7 +63,7 @@ class SimpleTable : public Table {
       : columns_(std::move(columns)) {
     schema_ = std::move(schema);
     if (num_rows < 0) {
-      if (columns_.size() == 0 || !columns_[0]) {
+      if (columns_.size() == 0) {
         num_rows_ = 0;
       } else {
         num_rows_ = columns_[0]->length();
@@ -77,7 +77,7 @@ class SimpleTable : public Table {
               const std::vector<std::shared_ptr<Array>>& columns, int64_t num_rows = -1) {
     schema_ = std::move(schema);
     if (num_rows < 0) {
-      if (columns.size() == 0 || !columns[0]) {
+      if (columns.size() == 0) {
         num_rows_ = 0;
       } else {
         num_rows_ = columns[0]->length();
@@ -260,12 +260,20 @@ std::vector<std::shared_ptr<Field>> Table::fields() const {
 std::shared_ptr<Table> Table::Make(std::shared_ptr<Schema> schema,
                                    std::vector<std::shared_ptr<ChunkedArray>> columns,
                                    int64_t num_rows) {
+  DCHECK_EQ(schema->num_fields(), static_cast<int>(columns.size()));
+  for (const auto& column : columns) {
+    DCHECK(column != nullptr) << "column should not be null";
+  }
   return std::make_shared<SimpleTable>(std::move(schema), std::move(columns), num_rows);
 }
 
 std::shared_ptr<Table> Table::Make(std::shared_ptr<Schema> schema,
                                    const std::vector<std::shared_ptr<Array>>& arrays,
                                    int64_t num_rows) {
+  DCHECK_EQ(schema->num_fields(), static_cast<int>(arrays.size()));
+  for (const auto& array : arrays) {
+    DCHECK(array != nullptr) << "array should not be null";
+  }
   return std::make_shared<SimpleTable>(std::move(schema), arrays, num_rows);
 }