deprecate ellipses

Author: thisisnic

r/R/dataset.R

@@ -481,7 +481,7 @@ FileSystemDataset <- R6Class(
       file_type <- self$format$type
       pretty_file_type <- list(
         parquet = "Parquet",
-        ipc = "IPC"
+        ipc = "Arrow IPC"
       )[[file_type]]
 
       paste(

r/R/ipc-stream.R

@@ -34,7 +34,16 @@
 #' tf <- tempfile()
 #' on.exit(unlink(tf))
 #' write_ipc_stream(mtcars, tf)
-write_ipc_stream <- function(x, sink) {
+write_ipc_stream <- function(x, sink, ...) {
+  if (length(list(...)) > 0) {
+    .Deprecated(
+      msg = paste(
+        "Extra arguments passed through `...` in `write_ipc_stream()`",
+        "are deprecated and ignored.",
+        "They will be removed in a future version."
+      )
+    )
+  }
   x_out <- x # So we can return the data we got
   x <- as_writable_table(x)
 
@@ -98,7 +107,16 @@ write_to_raw <- function(x, format = c("stream", "file")) {
 #' with `as_data_frame = FALSE` and calling `$ValidateFull()` on the Table
 #' before processing.
 #' @export
-read_ipc_stream <- function(file, as_data_frame = TRUE) {
+read_ipc_stream <- function(file, as_data_frame = TRUE, ...) {
+  if (length(list(...)) > 0) {
+    .Deprecated(
+      msg = paste(
+        "Extra arguments passed through `...` in `read_ipc_stream()`",
+        "are deprecated and ignored.",
+        "They will be removed in a future version."
+      )
+    )
+  }
   if (!inherits(file, "InputStream")) {
     file <- make_readable_file(file, random_access = FALSE)
     on.exit(file$close())