Skip to content

Commit e09e2d1

Browse files
committed
Enable Remote Testing With Dremio Instance
* Disable non-odbc workflows * Install `netcat` and set `ARROW_FLIGHT_SQL_ODBC_CONN` * Attempt to enable docker network Update compose.yaml Add executable bash script * add commands for testing Dremio instance value * Change to use `host.docker.internal` * Change test to run remote test Update cpp_extra.yml * Use `localhost` as hostname * Use `dremio_container` as host * Clean up PR * Test remote instance * CI can connect to remote instance, revert "Test remote instance" This reverts commit db975bf. * Disable ODBC Debian build * Seeing segfault at ODBC test. Can probably be solved by passing test linkage = static like we did with Ubuntu. Since we don't have capacity to work on Debian now, we can close this.
1 parent e97ab4c commit e09e2d1

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

.github/workflows/cpp_extra.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -369,6 +369,12 @@ jobs:
369369
with:
370370
fetch-depth: 0
371371
submodules: recursive
372+
- name: Create Docker Test Network
373+
run: docker network create odbc_net
374+
- name: Set Up Dremio Instance
375+
run: |
376+
docker compose -f cpp/src/arrow/flight/sql/odbc/tests/dremio/docker-compose.yml up -d
377+
cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh
372378
- name: Cache Docker Volumes
373379
uses: actions/cache@v5
374380
with:

compose.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,11 @@ volumes:
204204
ubuntu-ccache:
205205
name: ${ARCH}-ubuntu-${UBUNTU}-ccache
206206

207+
networks:
208+
# GH-48068 for Flight SQL ODBC Testing
209+
odbc_net:
210+
external: true
211+
207212
services:
208213

209214
################################# C++ #######################################
@@ -509,6 +514,7 @@ services:
509514
ARROW_DEPENDENCY_SOURCE: BUNDLED
510515
ARROW_DEPENDENCY_USE_SHARED: "OFF"
511516
ARROW_FLIGHT_SQL_ODBC: "ON"
517+
ARROW_FLIGHT_SQL_ODBC_CONN: "driver={Apache Arrow Flight SQL ODBC Driver};HOST=dremio_container;port=32010;pwd=admin2025;uid=admin;useEncryption=false;UseWideChar=true;"
512518
ARROW_GANDIVA: "OFF"
513519
ARROW_GCS: "OFF"
514520
ARROW_HDFS: "OFF"
@@ -517,6 +523,8 @@ services:
517523
ARROW_S3: "OFF"
518524
ARROW_SUBSTRAIT: "OFF"
519525
# Register ODBC before running tests
526+
networks:
527+
- odbc_net
520528
command: >
521529
/bin/bash -c "
522530
/arrow/ci/scripts/cpp_build.sh /arrow /build &&

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18-
# GH-48068 TODO: run remote ODBC tests on Linux
19-
2018
#!/bin/bash
2119
set -e
2220

0 commit comments

Comments
 (0)