Commit ce1915a
authored
### Rationale for this change
By default, C++ debug builds with MSVC output debug information in separate PDB files. However, that is [not supported by ccache](ccache/ccache#1040), hence compilation caching does not work on those builds and they are always slower than desired.
### What changes are included in this PR?
On MSVC-based CI builds, embed debug information in object files instead of PDB files, to make ccache effective.
### Are these changes tested?
Yes, on existing CI builds.
Sample build times without this PR:
* [AMD64 Windows 2022 AVX2 C++](https://github.com/apache/arrow/actions/runs/28687053996/job/85081568536): 24m33s compilation (31m37s total)
* [AMD64 Windows MSVC GLib](https://github.com/apache/arrow/actions/runs/28779670304/job/85331985342#logs): 12m47s compilation (15m29s total)
With this PR:
* [AMD64 Windows 2022 AVX2 C++](https://github.com/apache/arrow/actions/runs/28782043058/job/85347470398?pr=50387#logs): 3m43s compilation (11m33s total)
* [AMD64 Windows MSVC GLib](https://github.com/apache/arrow/actions/runs/28782042798/job/85344623354?pr=50387#logs): 3m25s compilation (5m50s total)
### Are there any user-facing changes?
No.
* GitHub Issue: #50388
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
1 parent 9f55c8d commit ce1915a
5 files changed
Lines changed: 8 additions & 18 deletions
File tree
- .github/workflows
- ci/scripts
- cpp/cmake_modules
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
| 76 | + | |
75 | 77 | | |
76 | 78 | | |
77 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
386 | 386 | | |
387 | 387 | | |
388 | 388 | | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
389 | 392 | | |
390 | 393 | | |
391 | 394 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| 272 | + | |
272 | 273 | | |
273 | 274 | | |
274 | 275 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | 238 | | |
257 | 239 | | |
258 | 240 | | |
| |||
0 commit comments