remove access to pygithub's private requester

Author: fangchenli

dev/archery/archery/crossbow/core.py

@@ -465,12 +465,9 @@ def as_github_repo(self, github_token=None):
     def token_expiration_date(self, github_token=None):
         """Returns the expiration date for the github_token provided"""
         github = self._github_login(github_token)
-        # NOTE: We access the private _Github__requester to get response
-        # headers, as PyGithub doesn't expose the token expiration header
-        # through its public API. This may break with future PyGithub updates.
-        headers, _ = github._Github__requester.requestJsonAndCheck(
-            "GET", "/user"
-        )
+        # PyGithub doesn't expose the token expiration header through a
+        # dedicated API, so request it via the public Requester escape hatch.
+        headers, _ = github.requester.requestJsonAndCheck("GET", "/user")
         # Response header in the form '2023-01-23 10:40:28 UTC'
         date_string = headers.get('github-authentication-token-expiration')
         if date_string:

dev/archery/archery/crossbow/tests/test_core.py

@@ -207,7 +207,7 @@ def test_token_expiration_date():
     with mock.patch.object(Repo, '_github_login') as mock_login:
         mock_github = mock.MagicMock()
         mock_login.return_value = mock_github
-        mock_github._Github__requester.requestJsonAndCheck.return_value = (
+        mock_github.requester.requestJsonAndCheck.return_value = (
             {'github-authentication-token-expiration': '2024-12-31 23:59:59 UTC'},
             {}
         )
@@ -223,7 +223,7 @@ def test_token_expiration_date_no_header():
     with mock.patch.object(Repo, '_github_login') as mock_login:
         mock_github = mock.MagicMock()
         mock_login.return_value = mock_github
-        mock_github._Github__requester.requestJsonAndCheck.return_value = (
+        mock_github.requester.requestJsonAndCheck.return_value = (
             {},
             {}
         )

dev/archery/setup.py

@@ -29,7 +29,7 @@
 
 extras = {
     'benchmark': ['pandas'],
-    'crossbow': ['pygithub', jinja_req, 'pygit2>=1.14.0', 'requests',
+    'crossbow': ['pygithub>=2.5.0', jinja_req, 'pygit2>=1.14.0', 'requests',
                  'ruamel.yaml', 'setuptools_scm>=8.0.0'],
     'docker': ['ruamel.yaml', 'python-dotenv'],
     'integration': ['cffi', 'numpy'],