Commit 96f8072
authored
I opted to delete the 'reexports' file because the symbols are not _actually_ re-exported. IMHO, it's more appropriate to just add this hook in arrow-package.R as done here, but of course if your strong preference is to retain the reexports-bit64.R file I'll restore it.
`integer64()` should be a fine choice -- I basically wanted a part of the API that has essentially 0 chance of ever changing.
As of today, `R CMD check` doesn't complain if you import a symbol and then don't reference it in the sources. Nor do I think such a check will ever happen.
* GitHub Issue: #50014
Lead-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Co-authored-by: Michael Chirico <chiricom@google.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
1 parent bf3de53 commit 96f8072
5 files changed
Lines changed: 2 additions & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
151 | 150 | | |
152 | 151 | | |
153 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
430 | | - | |
431 | | - | |
| 430 | + | |
432 | 431 | | |
433 | 432 | | |
434 | 433 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
| |||
This file was deleted.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments