Skip to content

Commit 96f8072

Browse files
GH-50014: [R] Replace imported symbol from bit64 (#50015)
I opted to delete the 'reexports' file because the symbols are not _actually_ re-exported. IMHO, it's more appropriate to just add this hook in arrow-package.R as done here, but of course if your strong preference is to retain the reexports-bit64.R file I'll restore it. `integer64()` should be a fine choice -- I basically wanted a part of the API that has essentially 0 chance of ever changing. As of today, `R CMD check` doesn't complain if you import a symbol and then don't reference it in the sources. Nor do I think such a check will ever happen. * GitHub Issue: #50014 Lead-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Michael Chirico <chiricom@google.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
1 parent bf3de53 commit 96f8072

5 files changed

Lines changed: 2 additions & 29 deletions

File tree

r/DESCRIPTION

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ Collate:
147147
'query-engine.R'
148148
'record-batch-reader.R'
149149
'record-batch-writer.R'
150-
'reexports-bit64.R'
151150
'reexports-tidyselect.R'
152151
'schema.R'
153152
'udf.R'

r/NAMESPACE

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,8 +427,7 @@ export(write_tsv_dataset)
427427
importFrom(R6,R6Class)
428428
importFrom(assertthat,assert_that)
429429
importFrom(assertthat,is.string)
430-
importFrom(bit64,print.integer64)
431-
importFrom(bit64,str.integer64)
430+
importFrom(bit64,integer64)
432431
importFrom(glue,glue)
433432
importFrom(methods,as)
434433
importFrom(purrr,as_mapper)

r/R/arrow-package.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#' @importFrom rlang is_bare_list call_name
3131
#' @importFrom tidyselect vars_pull eval_select eval_rename
3232
#' @importFrom glue glue
33+
#' @importFrom bit64 integer64
3334
#' @useDynLib arrow, .registration = TRUE
3435
#' @keywords internal
3536
"_PACKAGE"

r/R/reexports-bit64.R

Lines changed: 0 additions & 22 deletions
This file was deleted.

r/man/reexports.Rd

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)