Address more feedback

Author: justing-bq

cpp/src/arrow/flight/sql/odbc/CMakeLists.txt

@@ -230,11 +230,9 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
     # Upgrade GUID is required to be unchanged for ODBC installer to upgrade
     set(CPACK_WIX_UPGRADE_GUID "DBF27A18-F8BF-423F-9E3A-957414D52C4B")
     set(CPACK_WIX_PRODUCT_GUID "279D087B-93B5-4DC3-BA69-BCF485022A26")
-  else()
+  elseif(APPLE)
     # macOS and Linux
-    if(APPLE)
-      set(CPACK_GENERATOR "productbuild")
-    endif()
+    set(CPACK_GENERATOR "productbuild")
   endif()
   # GH-47877 TODO: create Linux Installer using cpack
 

cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc.sh

@@ -17,7 +17,7 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# Used by arrow/cpp/src/arrow/flight/sql/odbc/install/mac/postinstall
+# Used by cpp/src/arrow/flight/sql/odbc/install/mac/postinstall
 
 set -euo pipefail
 

cpp/src/arrow/flight/sql/odbc/install/unix/install_odbc_ini.sh

@@ -70,6 +70,9 @@ if grep -q '^\[ODBC Data Sources\]' "$SYSTEM_ODBC_FILE"; then
     ' "$SYSTEM_ODBC_FILE" > "$tmp_file"
 
     mv "$tmp_file" "$SYSTEM_ODBC_FILE"
+
+    # Restore expected permissions/ownership for system ODBC config
+    chmod 644 "$SYSTEM_ODBC_FILE"
   fi
 else
   # Section doesn't exist, append section and DSN entry at end