Skip to content

Commit 80359ae

Browse files
committed
arrow-filesystem-test shouldn't require s3fs_module_test.cc as it is covered on s3fs_module_test and s3fs_module_test doesn't make sense on static builds
1 parent 93c48e5 commit 80359ae

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

cpp/src/arrow/filesystem/CMakeLists.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ if(ARROW_S3)
129129
endif()
130130
endif()
131131

132-
if(ARROW_BUILD_TESTS)
132+
if(ARROW_BUILD_TESTS AND ARROW_BUILD_SHARED)
133133
add_arrow_test(s3fs_module_test
134134
SOURCES
135135
s3fs_module_test.cc
@@ -140,10 +140,6 @@ if(ARROW_S3)
140140
ARROW_S3_LIBPATH="$<TARGET_FILE:arrow_s3_shared>"
141141
EXTRA_LINK_LIBS
142142
Boost::filesystem)
143-
target_compile_definitions(arrow-filesystem-test
144-
PUBLIC ARROW_S3_LIBPATH="$<TARGET_FILE:arrow_s3_shared>")
145-
target_sources(arrow-filesystem-test PUBLIC s3fs_module_test.cc s3_test_util.cc)
146-
target_link_libraries(arrow-filesystem-test PUBLIC Boost::filesystem)
147143
endif()
148144
endif()
149145

0 commit comments

Comments
 (0)