Commit 793fb89
authored
MINOR: [R][Dev] Fix silent CMake failure in nixlibs.R with CMake>4 (#49865)
### Rationale for this change
On my Mac, when I try to install the R package from main, I get a confusing warning that S3 support is disabled:
```
**** cmake 4.3.0: /opt/homebrew/bin/cmake
**** S3 support requires libcurl-devel (rpm) or libcurl4-openssl-dev (deb) ; building with ARROW_S3=OFF
```
I figured out we were getting a failure from the cmake invocation,
```
CMake Error in CMakeLists.txt:
No cmake_minimum_required command is present. A line of code such as
cmake_minimum_required(VERSION 4.3)
should be added at the top of the file. The version specified may be lower
if you wish to support older CMake versions for this project. For more
information run "cmake --help-policy CMP0000".
```
but silently ignoring it because the subprocess call hardcoded ignoring stdout/stderr.
### What changes are included in this PR?
- Fixes the issue with cmake by specifying `cmake_minimum_required`
- Makes the cmake command respect `quietly` (ARROW_R_DEV) so we don't swallow errors
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: Bryce Mecum <petridish@gmail.com>1 parent f5183b1 commit 793fb89
1 file changed
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
923 | 923 | | |
924 | 924 | | |
925 | 925 | | |
926 | | - | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
927 | 934 | | |
928 | 935 | | |
929 | 936 | | |
| |||
936 | 943 | | |
937 | 944 | | |
938 | 945 | | |
939 | | - | |
| 946 | + | |
940 | 947 | | |
941 | 948 | | |
942 | 949 | | |
| |||
0 commit comments