Skip to content

Commit 6917793

Browse files
committed
Temporarily exclude arrow-s3fs-module-test if not minio before a better solution is found
1 parent 07fa9cc commit 6917793

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

.github/workflows/cpp_extra.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,9 @@ jobs:
341341
PARQUET_TEST_DATA: ${{ github.workspace }}/cpp/submodules/parquet-testing/data
342342
run: |
343343
# MinIO is required
344+
# TODO: This doesn't seem like a good solution
344345
exclude_tests="arrow-s3fs-test"
346+
exclude_tests="${exclude_tests}|arrow-s3fs-module-test"
345347
# unstable
346348
exclude_tests="${exclude_tests}|arrow-acero-asof-join-node-test"
347349
exclude_tests="${exclude_tests}|arrow-acero-hash-join-node-test"

ci/scripts/cpp_test.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ if ! type storage-testbench >/dev/null 2>&1; then
5151
exclude_tests+=("arrow-gcsfs-test")
5252
fi
5353
if ! type minio >/dev/null 2>&1; then
54+
# TODO: This doesn't seem like a good solution
55+
# We are excluding tests that shouldn't be excluded
5456
exclude_tests+=("arrow-s3fs-test")
57+
exclude_tests+=("arrow-s3fs-module-test")
5558
fi
5659
case "$(uname)" in
5760
Linux)
@@ -60,7 +63,9 @@ case "$(uname)" in
6063
Darwin)
6164
n_jobs=$(sysctl -n hw.ncpu)
6265
# TODO: https://github.com/apache/arrow/issues/40410
66+
# TODO: This is not a good solution
6367
exclude_tests+=("arrow-s3fs-test")
68+
exclude_tests+=("arrow-s3fs-module-test")
6469
;;
6570
MINGW*)
6671
n_jobs=${NUMBER_OF_PROCESSORS:-1}

0 commit comments

Comments
 (0)