Address review feedback

Author: justing-bq

cpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc

@@ -127,8 +127,7 @@ TYPED_TEST(ConnectionAttributeTest, TestSQLSetConnectAttrTraceDMOnly) {
 TYPED_TEST(ConnectionAttributePreConnectTest, TestSQLSetConnectAttrTracefileDMOnly) {
   // Verify DM-only attribute is handled by Driver Manager
 
-  // Use placeholder value as we want the call to fail, or else
-  // the driver manager will produce a trace file.
+  // Use placeholder value to avoid the driver manager from producing a trace file.
   std::wstring trace_file = L"invalid/file/path";
   std::vector<SQLWCHAR> trace_file0(trace_file.begin(), trace_file.end());
 

cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc

@@ -339,9 +339,9 @@ TYPED_TEST(ConnectionInfoTest, TestSQLGetInfoOdbcVer) {
   EXPECT_EQ(std::wstring(L"03.52.0000"), result);
 #elif defined(__linux__)
   EXPECT_EQ(std::wstring(L"03.52"), result);
-#else   // WINDOWS
+#else  // WINDOWS
   EXPECT_EQ(std::wstring(L"03.80.0000"), result);
-#endif  // __APPLE__
+#endif
 }
 
 TYPED_TEST(ConnectionInfoTest, TestSQLGetInfoParamArrayRowCounts) {

cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h

@@ -246,7 +246,6 @@ bool CompareConnPropertyMap(Connection::ConnPropertyMap map1,
 /// Get error message from ODBC driver using SQLGetDiagRec
 std::string GetOdbcErrorMessage(SQLSMALLINT handle_type, SQLHANDLE handle);
 
-static constexpr std::string_view kErrorState00000 = "00000";
 static constexpr std::string_view kErrorState01004 = "01004";
 static constexpr std::string_view kErrorState01S02 = "01S02";
 static constexpr std::string_view kErrorState01S07 = "01S07";

cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc

@@ -1043,7 +1043,7 @@ TEST_F(StatementMockTest, TestSQLExecDirectVarbinaryTruncation) {
   ASSERT_EQ(SQL_SUCCESS,
             SQLGetData(this->stmt, 1, SQL_C_BINARY, &varbinary_val2[0], buf_len, &ind));
 
-  EXPECT_EQ(static_cast<char>('\xAB'), static_cast<char>(varbinary_val[0]));
+  EXPECT_EQ(static_cast<char>('\xAB'), static_cast<char>(varbinary_val2[0]));
   EXPECT_EQ(1, ind);
 
   // Attempt to fetch data 3rd time
@@ -1988,7 +1988,6 @@ TYPED_TEST(StatementTest, TestSQLMoreResultsInvalidFunctionSequence) {
   // without executing any queries
 #ifdef __linux__
   ASSERT_EQ(SQL_NO_DATA, SQLMoreResults(this->stmt));
-  VerifyOdbcErrorState(SQL_HANDLE_STMT, this->stmt, kErrorState00000);
 #else  // Windows & Mac
   ASSERT_EQ(SQL_ERROR, SQLMoreResults(this->stmt));
   VerifyOdbcErrorState(SQL_HANDLE_STMT, this->stmt, kErrorStateHY010);