try to fix tz issue under wasm

Author: amoeba

cpp/src/arrow/vendored/datetime/visibility.h

@@ -17,7 +17,7 @@
 
 #pragma once
 
-#ifndef _WIN32
+#if !defined(_WIN32) && !defined(__EMSCRIPTEN__)
 #  define USE_OS_TZDB 1
 #endif
 

r/tests/testthat/test-dataset-dplyr.R

@@ -70,7 +70,7 @@ test_that("filter() with %in%", {
 })
 
 test_that("filter() on timestamp columns", {
-  skip_on_emscripten()
+  # skip_on_emscripten()  # TODO: remove if timezone fix (visibility.h) works
   skip_if_not_available("re2")
 
   ds <- open_dataset(dataset_dir, partitioning = schema(part = uint8()))
@@ -120,7 +120,7 @@ test_that("filter() on date32 columns", {
   )
 
   skip_if_not_available("re2")
-  skip_on_emscripten()
+  # skip_on_emscripten()  # TODO: remove if timezone fix (visibility.h) works
 
   # Also with timestamp scalar
   expect_equal(

r/tests/testthat/test-dplyr-arrange.R

@@ -238,7 +238,7 @@ test_that("Can use across() within arrange()", {
       collect(),
     example_data
   )
-  skip_on_emscripten()
+  # skip_on_emscripten() # TODO: Unrelated to timezone fix; passing a bare function (desc) to across() .fns fails on Emscripten
   compare_dplyr_binding(
     .input |>
       arrange(across(starts_with("d"), desc)) |>

r/tests/testthat/test-dplyr-filter.R

@@ -25,7 +25,11 @@ tbl <- example_data
 tbl$verses <- verses[[1]]
 # c(" a ", "  b  ", "   c   ", ...) increasing padding
 # nchar =   3  5  7  9 11 13 15 17 19 21
-tbl$padded_strings <- stringr::str_pad(letters[1:10], width = 2 * (1:10) + 1, side = "both")
+tbl$padded_strings <- stringr::str_pad(
+  letters[1:10],
+  width = 2 * (1:10) + 1,
+  side = "both"
+)
 tbl$some_negative <- tbl$int * (-1)^(1:nrow(tbl)) # nolint
 
 test_that("filter() on is.na()", {
@@ -415,7 +419,7 @@ test_that("filter() with namespaced functions", {
 })
 
 test_that("filter() with across()", {
-  skip_on_emscripten()
+  #  skip_on_emscripten() # TODO: Remove if timezone fix works
 
   compare_dplyr_binding(
     .input |>

r/tests/testthat/test-dplyr-query.R

@@ -646,7 +646,7 @@ test_that("Scalars in expressions match the type of the field, if possible", {
   # it merges.
   # https://github.com/r-hub/rhub-linux-builders/pull/65
   skip_if(identical(Sys.timezone(), "/UTC"))
-  skip_on_emscripten()
+  # skip_on_emscripten()  # TODO: remove if timezone fix (visibility.h) works
 
   expect_output(
     tab |>