Continue work on kou's comments

- Use `target_link_libraries` for `c-ares`.
- Use one `add_arrow_lib`

Author: alinaliBQ

cpp/cmake_modules/ThirdpartyToolchain.cmake

@@ -3041,8 +3041,7 @@ function(build_cares)
   if(APPLE)
     # libresolv must be linked from c-ares version 1.16.1
     find_library(LIBRESOLV_LIBRARY NAMES resolv libresolv REQUIRED)
-    set_target_properties(c-ares PROPERTIES INTERFACE_LINK_LIBRARIES
-                                            "${LIBRESOLV_LIBRARY}")
+    target_link_libraries(c-ares INTERFACE ${LIBRESOLV_LIBRARY})
   endif()
 
   set(ARROW_BUNDLED_STATIC_LIBS

cpp/src/arrow/flight/sql/odbc/CMakeLists.txt

@@ -59,54 +59,47 @@ endif()
 
 # On Windows, dynmaic build for ODBC is supported.
 # On unix systems, static build for ODBC is supported, all libraries are linked statically on unix.
+set(ARROW_FLIGHT_SQL_ODBC_SHARED_INSTALL_INTERFACE_LIBS "")
+set(ARROW_FLIGHT_SQL_ODBC_STATIC_INSTALL_INTERFACE_LIBS "")
+set(ARROW_FLIGHT_SQL_ODBC_SHARED_PRIVATE_LINK_LIBS "")
 if(WIN32)
-  add_arrow_lib(arrow_flight_sql_odbc
-                CMAKE_PACKAGE_NAME
-                ArrowFlightSqlOdbc
-                PKG_CONFIG_NAME
-                arrow-flight-sql-odbc
-                OUTPUTS
-                ARROW_FLIGHT_SQL_ODBC_LIBRARIES
-                SOURCES
-                ${ARROW_FLIGHT_SQL_ODBC_SRCS}
-                DEFINITIONS
-                UNICODE
-                SHARED_LINK_FLAGS
-                ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
-                SHARED_LINK_LIBS
-                arrow_flight_sql_shared
-                arrow_odbc_spi_impl
-                SHARED_INSTALL_INTERFACE_LIBS
-                ArrowFlight::arrow_flight_sql_shared
-                STATIC_LINK_LIBS
-                arrow_flight_sql_static
-                STATIC_INSTALL_INTERFACE_LIBS
-                ArrowFlight::arrow_flight_sql_static
-                SHARED_PRIVATE_LINK_LIBS
-                ODBC::ODBC
-                ${ODBCINST})
+  set(ARROW_FLIGHT_SQL_ODBC_SHARED_LINK_LIBS arrow_flight_sql_shared arrow_odbc_spi_impl)
+  set(ARROW_FLIGHT_SQL_ODBC_STATIC_LINK_LIBS arrow_flight_sql_static)
+  list(APPEND ARROW_FLIGHT_SQL_ODBC_SHARED_INSTALL_INTERFACE_LIBS
+       ArrowFlight::arrow_flight_sql_shared)
+  list(APPEND ARROW_FLIGHT_SQL_ODBC_STATIC_INSTALL_INTERFACE_LIBS
+       ArrowFlight::arrow_flight_sql_static)
+  list(APPEND ARROW_FLIGHT_SQL_ODBC_SHARED_PRIVATE_LINK_LIBS ODBC::ODBC ${ODBCINST})
 else()
   # Unix
-  add_arrow_lib(arrow_flight_sql_odbc
-                CMAKE_PACKAGE_NAME
-                ArrowFlightSqlOdbc
-                PKG_CONFIG_NAME
-                arrow-flight-sql-odbc
-                OUTPUTS
-                ARROW_FLIGHT_SQL_ODBC_LIBRARIES
-                SOURCES
-                ${ARROW_FLIGHT_SQL_ODBC_SRCS}
-                DEFINITIONS
-                UNICODE
-                SHARED_LINK_FLAGS
-                ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
-                STATIC_LINK_LIBS
-                ODBC::ODBC
-                ${ODBCINST}
-                SHARED_LINK_LIBS
-                arrow_odbc_spi_impl)
+  set(ARROW_FLIGHT_SQL_ODBC_SHARED_LINK_LIBS arrow_odbc_spi_impl)
+  set(ARROW_FLIGHT_SQL_ODBC_STATIC_LINK_LIBS ODBC::ODBC ${ODBCINST})
 endif()
 
+add_arrow_lib(arrow_flight_sql_odbc
+              CMAKE_PACKAGE_NAME
+              ArrowFlightSqlOdbc
+              PKG_CONFIG_NAME
+              arrow-flight-sql-odbc
+              OUTPUTS
+              ARROW_FLIGHT_SQL_ODBC_LIBRARIES
+              SOURCES
+              ${ARROW_FLIGHT_SQL_ODBC_SRCS}
+              DEFINITIONS
+              UNICODE
+              SHARED_LINK_FLAGS
+              ${ARROW_VERSION_SCRIPT_FLAGS} # Defined in cpp/arrow/CMakeLists.txt
+              SHARED_LINK_LIBS
+              ${ARROW_FLIGHT_SQL_ODBC_SHARED_LINK_LIBS}
+              SHARED_INSTALL_INTERFACE_LIBS
+              ${ARROW_FLIGHT_SQL_ODBC_SHARED_INSTALL_INTERFACE_LIBS}
+              STATIC_LINK_LIBS
+              ${ARROW_FLIGHT_SQL_ODBC_STATIC_LINK_LIBS}
+              STATIC_INSTALL_INTERFACE_LIBS
+              ${ARROW_FLIGHT_SQL_ODBC_STATIC_INSTALL_INTERFACE_LIBS}
+              SHARED_PRIVATE_LINK_LIBS
+              ${ARROW_FLIGHT_SQL_ODBC_SHARED_PRIVATE_LINK_LIBS})
+
 foreach(LIB_TARGET ${ARROW_FLIGHT_SQL_ODBC_LIBRARIES})
   target_compile_definitions(${LIB_TARGET} PRIVATE ARROW_FLIGHT_SQL_ODBC_EXPORTING)
 endforeach()

cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt

@@ -53,31 +53,24 @@ set(ARROW_FLIGHT_SQL_ODBC_TEST_SRCS
 # On Windows, dynamic linking ODBC is supported, tests link libraries dynamically.
 # On unix systems, static linking ODBC is supported, thus tests link libraries statically.
 if(WIN32)
-  add_arrow_test(flight_sql_odbc_test
-                 SOURCES
-                 ${ARROW_FLIGHT_SQL_ODBC_TEST_SRCS}
-                 ${ARROW_FLIGHT_SQL_MOCK_SERVER_SRCS}
-                 DEFINITIONS
-                 UNICODE
-                 EXTRA_LINK_LIBS
-                 ${ODBC_LIBRARIES}
-                 ${ODBCINST}
-                 ${SQLite3_LIBRARIES}
-                 ${ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS})
-elseif(APPLE)
-  add_arrow_test(flight_sql_odbc_test
-                 SOURCES
-                 ${ARROW_FLIGHT_SQL_ODBC_TEST_SRCS}
-                 ${ARROW_FLIGHT_SQL_MOCK_SERVER_SRCS}
-                 DEFINITIONS
-                 UNICODE
-                 STATIC_LINK_LIBS
-                 ${ODBC_LIBRARIES}
-                 ${ODBCINST}
-                 ${SQLite3_LIBRARIES}
-                 ${ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS})
+  set(ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS_TYPE EXTRA_LINK_LIBS)
+else()
+  # Unix
+  set(ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS_TYPE STATIC_LINK_LIBS)
 endif()
 
+add_arrow_test(flight_sql_odbc_test
+               SOURCES
+               ${ARROW_FLIGHT_SQL_ODBC_TEST_SRCS}
+               ${ARROW_FLIGHT_SQL_MOCK_SERVER_SRCS}
+               DEFINITIONS
+               UNICODE
+               ${ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS_TYPE}
+               ${ODBC_LIBRARIES}
+               ${ODBCINST}
+               ${SQLite3_LIBRARIES}
+               ${ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS})
+
 find_package(ODBC REQUIRED)
 target_link_libraries(arrow-flight-sql-odbc-test PRIVATE ODBC::ODBC)