Skip to content

Commit 2f706aa

Browse files
committed
Try adding protobug to ARROW_SHARED_PRIVATE_LINK_LIBS if ORC bundled to expose symbols
1 parent 569ea7d commit 2f706aa

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

cpp/src/arrow/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,6 +1024,12 @@ if(ARROW_ORC)
10241024
PRIVATE ARROW_ORC_NEED_TIME_ZONE_DATABASE_CHECK)
10251025
endif()
10261026
endforeach()
1027+
# On Windows (MSVC), ORC links protobuf PRIVATE so protobuf symbols
1028+
# don't propagate through the OBJECT library chain to arrow.dll.
1029+
# Add protobuf directly to ensure it appears on the link line.
1030+
if(MSVC)
1031+
list(APPEND ARROW_SHARED_PRIVATE_LINK_LIBS ${ARROW_PROTOBUF_LIBPROTOBUF})
1032+
endif()
10271033
else()
10281034
set(ARROW_ORC_TARGET_SHARED)
10291035
set(ARROW_ORC_TARGET_STATIC)

0 commit comments

Comments
 (0)